[Lldb-commits] [PATCH] D112586: [lldb] Remove forgotten FIXME on CPlusPlus formatters

2021-10-29 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGac73f567cffb: [lldb] Remove forgotten FIXME on CPlusPlus formatters (authored by ljmf00, committed by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D112586: [lldb] Remove forgotten FIXME on CPlusPlus formatters

2021-10-28 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. In D112586#3094519 , @ljmf00 wrote: > In D112586#3093490 , @teemperor > wrote: > >> LGTM, thanks. > > Note: I can't land it I can land it for you tomorrow (unless someone beats me to

[Lldb-commits] [PATCH] D112586: [lldb] Remove forgotten FIXME on CPlusPlus formatters

2021-10-28 Thread Luís Ferreira via Phabricator via lldb-commits
ljmf00 added a comment. In D112586#3093490 , @teemperor wrote: > LGTM, thanks. Note: I can't land it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112586/new/ https://reviews.llvm.org/D112586

[Lldb-commits] [PATCH] D112586: [lldb] Remove forgotten FIXME on CPlusPlus formatters

2021-10-28 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added subscribers: labath, teemperor. teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112586/new/

[Lldb-commits] [PATCH] D112586: [lldb] Remove forgotten FIXME on CPlusPlus formatters

2021-10-26 Thread Luís Ferreira via Phabricator via lldb-commits
ljmf00 created this revision. ljmf00 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The patch [1] introduced this FIXME but ended up not being removed when fixed. [1]: