[Lldb-commits] [PATCH] D113163: [LLDB][Breakpad] Create a function for each compilation unit.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfbf665a0086c: [LLDB][Breakpad] Create a function for each compilation unit. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D113163: [LLDB][Breakpad] Create a function for each compilation unit.

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:337 + std::lock_guard guard(GetModuleMutex()); + if (!(name_type_mask &

[Lldb-commits] [PATCH] D113163: [LLDB][Breakpad] Create a function for each compilation unit.

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:337 + std::lock_guard guard(GetModuleMutex()); + if (!(name_type_mask & eFunctionNameTypeMethod)) +return; labath wrote: > How did you come to pick

[Lldb-commits] [PATCH] D113163: [LLDB][Breakpad] Create a function for each compilation unit.

zequanwu updated this revision to Diff 385896. zequanwu marked 3 inline comments as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113163/new/ https://reviews.llvm.org/D113163 Files:

[Lldb-commits] [PATCH] D113163: [LLDB][Breakpad] Create a function for each compilation unit.

labath added a comment. Sorry for the delay. Just a couple of (hopefully final) requests. Comment at: lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:245 +addr_t address = record->Address + base; +SectionSP section_sp =

[Lldb-commits] [PATCH] D113163: [LLDB][Breakpad] Create a function for each compilation unit.

zequanwu updated this revision to Diff 385109. zequanwu added a comment. Add FindFunctions. Remove the loop that adds FUNC to symtab. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113163/new/ https://reviews.llvm.org/D113163 Files:

[Lldb-commits] [PATCH] D113163: [LLDB][Breakpad] Create a function for each compilation unit.

labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:388-392 for (llvm::StringRef line : lines(Record::Func)) { if (auto record = FuncRecord::parse(line)) add_symbol(record->Address, record->Size, record->Name);

[Lldb-commits] [PATCH] D113163: [LLDB][Breakpad] Create a function for each compilation unit.

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:388-392 for (llvm::StringRef line : lines(Record::Func)) { if (auto record = FuncRecord::parse(line)) add_symbol(record->Address, record->Size,

[Lldb-commits] [PATCH] D113163: [LLDB][Breakpad] Create a function for each compilation unit.

labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:388-392 for (llvm::StringRef line : lines(Record::Func)) { if (auto record = FuncRecord::parse(line)) add_symbol(record->Address, record->Size, record->Name);

[Lldb-commits] [PATCH] D113163: [LLDB][Breakpad] Create a function for each compilation unit.

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:388-392 for (llvm::StringRef line : lines(Record::Func)) { if (auto record = FuncRecord::parse(line)) add_symbol(record->Address, record->Size,

[Lldb-commits] [PATCH] D113163: [LLDB][Breakpad] Create a function for each compilation unit.

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:388-392 for (llvm::StringRef line : lines(Record::Func)) { if (auto record = FuncRecord::parse(line)) add_symbol(record->Address, record->Size,

[Lldb-commits] [PATCH] D113163: [LLDB][Breakpad] Create a function for each compilation unit.

labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:388-392 for (llvm::StringRef line : lines(Record::Func)) { if (auto record = FuncRecord::parse(line)) add_symbol(record->Address, record->Size, record->Name);

[Lldb-commits] [PATCH] D113163: [LLDB][Breakpad] Create a function for each compilation unit.

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:388-392 for (llvm::StringRef line : lines(Record::Func)) { if (auto record = FuncRecord::parse(line)) add_symbol(record->Address, record->Size,

[Lldb-commits] [PATCH] D113163: [LLDB][Breakpad] Create a function for each compilation unit.

zequanwu updated this revision to Diff 384815. zequanwu marked an inline comment as done. zequanwu added a comment. Add tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113163/new/ https://reviews.llvm.org/D113163 Files:

[Lldb-commits] [PATCH] D113163: [LLDB][Breakpad] Create a function for each compilation unit.

labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:388-392 for (llvm::StringRef line : lines(Record::Func)) { if (auto record = FuncRecord::parse(line)) add_symbol(record->Address, record->Size, record->Name);

[Lldb-commits] [PATCH] D113163: [LLDB][Breakpad] Create a function for each compilation unit.

zequanwu created this revision. zequanwu added a reviewer: labath. zequanwu requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald added a project: LLDB. Since every FUNC record (in breakpad) is a compilation unit, creating