This revision was automatically updated to reflect the committed changes.
JDevlieghere marked an inline comment as done.
Closed by commit rG6d48e2505c7a: [lldb] Use std::string instead of llvm::Twine
in GDBRemoteCommunicationClient (authored by JDevlieghere).
Herald added a project: LLDB.
Changed
JDevlieghere marked an inline comment as done.
JDevlieghere added a subscriber: david.
JDevlieghere added a comment.
@David: Yes, I considered it, but I think this is slightly more readable.
Comment at:
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:11
mgorny accepted this revision.
mgorny added inline comments.
Comment at:
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:1113
+std::string packet =
+"QEnableCompression:type:" + std::string(avail_name) + ";";
+if (SendPacketAndWaitForRespo
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
Looks good to me.
Alternatively the string concatenation could be inlined, then the Twine usage
would be correct - but would still need an explicit "str()", like this:
SendPacketAndWait
JDevlieghere created this revision.
JDevlieghere added a reviewer: mgorny.
JDevlieghere requested review of this revision.
>From the documentation:
> A Twine is not intended for use directly and should not be stored, its
> implementation relies on the ability to store pointers to temporary stack
