[Lldb-commits] [PATCH] D113604: [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h

This revision was automatically updated to reflect the committed changes. Closed by commit rGefefc4ee3b25: [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h (authored by ljmf00). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113604/new/ https://rev

[Lldb-commits] [PATCH] D113604: [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks alright CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113604/new/ https://reviews.llvm.org/D113604 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D113604: [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h

ljmf00 added a comment. Sorry for the delay. Can you re-review this @dblaikie ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113604/new/ https://reviews.llvm.org/D113604 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists

[Lldb-commits] [PATCH] D113604: [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h

ljmf00 updated this revision to Diff 394001. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113604/new/ https://reviews.llvm.org/D113604 Files: lldb/include/lldb/Symbol/Type.h lldb/source/Symbol/Type.cpp Index: lldb/source/Symbol/Type.cpp

[Lldb-commits] [PATCH] D113604: [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h

dblaikie requested changes to this revision. dblaikie added inline comments. This revision now requires changes to proceed. Comment at: lldb/include/lldb/Symbol/Type.h:204-206 + static bool GetTypeScopeAndBasename(const llvm::StringRef name, +

[Lldb-commits] [PATCH] D113604: [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h

dblaikie added inline comments. Comment at: lldb/include/lldb/Symbol/Type.h:205-206 + static bool GetTypeScopeAndBasename(const llvm::StringRef name, + llvm::StringRef scope, + llvm::StringRef basename,

[Lldb-commits] [PATCH] D113604: [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f99e1aa58e3: [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h (authored by ljmf00). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113604/new/ https://rev