[Lldb-commits] [PATCH] D113616: [lldb] Hyphenate Objective-C exception breakpoint labels ✍️

2022-03-01 Thread Stephane Moore via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0ff290570965: [lldb] Hyphenate Objective-C exception breakpoint labels ✍️ (authored by stephanemoore). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D113616: [lldb] Hyphenate Objective-C exception breakpoint labels ✍️

2022-03-01 Thread Stephane Moore via Phabricator via lldb-commits
stephanemoore added a comment. Herald added a project: All. In D113616#3347980 , @clayborg wrote: > Very easy change as VS Code IDE displays these strings and no one references > these by name. I thought so! Thanks for confirming! Repository: rG

[Lldb-commits] [PATCH] D113616: [lldb] Hyphenate Objective-C exception breakpoint labels ✍️

2022-02-27 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. Very easy change as VS Code IDE displays these strings and no one references these by name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113616/new/ https://reviews.llvm.org/D113616

[Lldb-commits] [PATCH] D113616: [lldb] Hyphenate Objective-C exception breakpoint labels ✍️

2022-02-23 Thread Stephane Moore via Phabricator via lldb-commits
stephanemoore added a comment. In D113616#3341803 , @JDevlieghere wrote: > This seems trivial enough, but adding Greg as he wrote most of lldb-vscode. Thanks!  I tried looking through the commit history but wasn't sure who would be a good candidate

[Lldb-commits] [PATCH] D113616: [lldb] Hyphenate Objective-C exception breakpoint labels ✍️

2022-02-23 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. This seems trivial enough, but adding Greg as he wrote most of lldb-vscode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113616/new/ https://reviews.llvm.org/D113616 ___

[Lldb-commits] [PATCH] D113616: [lldb] Hyphenate Objective-C exception breakpoint labels ✍️

2022-02-23 Thread Michael Wyman via Phabricator via lldb-commits
mwyman accepted this revision. mwyman added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113616/new/ https://reviews.llvm.org/D113616

[Lldb-commits] [PATCH] D113616: [lldb] Hyphenate Objective-C exception breakpoint labels ✍️

2022-02-23 Thread Stephane Moore via Phabricator via lldb-commits
stephanemoore created this revision. stephanemoore updated this revision to Diff 410926. stephanemoore added a comment. stephanemoore added reviewers: mwyman, jingham. stephanemoore published this revision for review. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Updated.