[Lldb-commits] [PATCH] D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster.

clayborg added a comment. In D115324#3857081 , @dblaikie wrote: > Been experimenting with this recently and I noticed that loading in the > cached indexes seems to do a lot of loading - specifically interning a lot of > strings from the index and the

[Lldb-commits] [PATCH] D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster.

dblaikie added a comment. Been experimenting with this recently and I noticed that loading in the cached indexes seems to do a lot of loading - specifically interning a lot of strings from the index and the symtab. Does this happen when reading a built-in index (apple_names/debug_names) (I

[Lldb-commits] [PATCH] D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster.

clayborg added a comment. Herald added a project: All. The unit testing I added to this patch was unable to catch a serious issue that I have fixed and is needed if anyone wants to enable this feature. So please make sure if you use this patch to also make sure that the following patch is also

[Lldb-commits] [PATCH] D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster.

clayborg added a comment. Some mac buildbots were failing due to "lldb/test/API/functionalities/module_cache/universal/TestModuleCacheUniversal.py" failing to build the executable with the makefile due to lack of arm64 support in the SDK that was being used. commit

[Lldb-commits] [PATCH] D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster.

clayborg added a comment. In D115324#3198913 , @stella.stamenova wrote: > The new test (TestModuleCacheSimple) is failing on the windows lldb bot. It > looks like the deletion of the executable is failing due to permissions and > other similar tests

[Lldb-commits] [PATCH] D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster.

stella.stamenova added a comment. The new test (TestModuleCacheSimple) is failing on the windows lldb bot. It looks like the deletion of the executable is failing due to permissions and other similar tests are skipped on windows for that reason. I haven't looked at the test in more detail to

[Lldb-commits] [PATCH] D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster.

This revision was automatically updated to reflect the committed changes. Closed by commit rGda816ca0cb3b: Added the ability to cache the finalized symbol tables subsequent debug… (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I think this is in a pretty good shape now. Thanks for your patience. Comment at: lldb/source/Symbol/Symbol.cpp:649 +/// The only tricky thing in this encoding is encoding

[Lldb-commits] [PATCH] D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster.

clayborg added a comment. Pavel: I fixed all issues you identified. Let me know if there is anything else you would like to see changed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115324/new/ https://reviews.llvm.org/D115324

[Lldb-commits] [PATCH] D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster.

clayborg added inline comments. Comment at: lldb/source/Core/Module.cpp:1679 + +std::string Module::GetCacheKey() { + std::string key; labath wrote: > The cache key and cache signature algorithms are fairly similar but subtly > different (IIUC, one is used to

[Lldb-commits] [PATCH] D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster.

clayborg updated this revision to Diff 394656. clayborg marked 7 inline comments as done. clayborg added a comment. - Fixed all review issues - Moved tests to separate test files in SymbolTests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster.

labath added a comment. Thanks for the quick response. I did another pass over the patch, and I think I have a fairly good understanding of how it works. I have another round of comments, but nothing major. Comment at: lldb/include/lldb/Core/DataFileCache.h:9 + +#ifndef

[Lldb-commits] [PATCH] D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster.

clayborg marked 6 inline comments as done. clayborg added a comment. Pavel: I fixed all issues you identified. Let me know if there is anything else you would like to see changed. Comment at: lldb/source/Host/common/FileSystem.cpp:523 + Status error; + if

[Lldb-commits] [PATCH] D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster.

clayborg updated this revision to Diff 394442. clayborg marked an inline comment as done. clayborg added a comment. Changes: - Updated Symtab class to not have to work around not having an object file and created a test with an object file - Don't use hack to encode Symbol bitfield values. -

[Lldb-commits] [PATCH] D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster.

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. The patch is slightly larger than I would prefer for a through review, but here's my first pass at it. I appreciate the difficulties in bootstrapping something like this

[Lldb-commits] [PATCH] D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115324/new/ https://reviews.llvm.org/D115324

[Lldb-commits] [PATCH] D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster.

clayborg marked 6 inline comments as done. clayborg added inline comments. Comment at: lldb/source/Utility/DataFileCache.cpp:58 + else +consumeError(cache_or_err.takeError()); +} wallace wrote: > could you create a new lldb log channel where this

[Lldb-commits] [PATCH] D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster.

clayborg updated this revision to Diff 394141. clayborg added a comment. Address all review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115324/new/ https://reviews.llvm.org/D115324 Files: lldb/include/lldb/Core/Mangled.h

[Lldb-commits] [PATCH] D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster.

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. much nicer than the first version. I'm just asking a few minor things. Comment at: lldb/include/lldb/Host/FileSystem.h:147 + /// + /// The path must specify a

[Lldb-commits] [PATCH] D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster.

clayborg updated this revision to Diff 394041. clayborg added a comment. Added string tables to the cache files. This allowed me to add the symbol table name indexes to the same symbol table cache file and share any strings from the normal symbol table. Repository: rG LLVM Github Monorepo