[Lldb-commits] [PATCH] D120195: Cleanup llvm/DebugInfo/PDB headers

MaskRay added a comment. In D120195#3334697 , @serge-sans-paille wrote: > In D120195#943 , @MaskRay wrote: > >> It'd be good to test `-DLLVM_ENABLE_MODULES=on` build. > > Sure, I'll add that to my local test

[Lldb-commits] [PATCH] D120195: Cleanup llvm/DebugInfo/PDB headers

serge-sans-paille added a comment. @thakis should be fixed by 57c6012213b50804ed78530b89bae30c0ee4fe82 , the new failure (seems) unrelated to this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D120195: Cleanup llvm/DebugInfo/PDB headers

thakis added a comment. Breaks building on win: http://45.33.8.238/win/53749/step_4.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120195/new/ https://reviews.llvm.org/D120195

[Lldb-commits] [PATCH] D120195: Cleanup llvm/DebugInfo/PDB headers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb4c8608115c: Cleanup llvm/DebugInfo/PDB headers (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D120195: Cleanup llvm/DebugInfo/PDB headers

serge-sans-paille added a comment. In D120195#943 , @MaskRay wrote: > It'd be good to test `-DLLVM_ENABLE_MODULES=on` build. Sure, I'll add that to my local test setup. > Some files get pure new headers. That's expected. It happens a lot when some

[Lldb-commits] [PATCH] D120195: Cleanup llvm/DebugInfo/PDB headers

serge-sans-paille added a comment. In D120195#942 , @MaskRay wrote: > before: 1065515095 > after: 1065629059 > > An increase? Ooopsie, a typo :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D120195: Cleanup llvm/DebugInfo/PDB headers

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. It'd be good to test `-DLLVM_ENABLE_MODULES=on` build. Some files get pure new headers. I still think it is good thing to do it separately. There is a risk that someone may revert the

[Lldb-commits] [PATCH] D120195: Cleanup llvm/DebugInfo/PDB headers

MaskRay added a comment. before: 1065515095 after: 1065629059 An increase? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120195/new/ https://reviews.llvm.org/D120195 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D120195: Cleanup llvm/DebugInfo/PDB headers

serge-sans-paille created this revision. serge-sans-paille added reviewers: RKSimon, MaskRay, lenary. Herald added a subscriber: hiraditya. serge-sans-paille requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. accumulated