[Lldb-commits] [PATCH] D121732: Avoid using a variable-sized array for a tiny allocation.

2022-03-15 Thread Sterling Augustine via Phabricator via lldb-commits
saugustine added inline comments. Comment at: lldb/source/Expression/DWARFExpression.cpp:1309 stack.back().GetScalar() = DerefSizeExtractDataHelper( -addr_bytes, sizeof(addr_bytes), objfile->GetByteOrder(), size); +addr_bytes, size,

[Lldb-commits] [PATCH] D121732: Avoid using a variable-sized array for a tiny allocation.

2022-03-15 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added inline comments. Comment at: lldb/source/Expression/DWARFExpression.cpp:1309 stack.back().GetScalar() = DerefSizeExtractDataHelper( -addr_bytes, sizeof(addr_bytes), objfile->GetByteOrder(), size); +addr_bytes, size,

[Lldb-commits] [PATCH] D121732: Avoid using a variable-sized array for a tiny allocation.

2022-03-15 Thread Sterling Augustine via Phabricator via lldb-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG7518e0ff63cd: Avoid using a variable-sized array for a tiny allocation. (authored by saugustine). Repository: rG LLVM

[Lldb-commits] [PATCH] D121732: Avoid using a variable-sized array for a tiny allocation.

2022-03-15 Thread Sterling Augustine via Phabricator via lldb-commits
saugustine created this revision. Herald added a project: All. saugustine requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D121732 Files: