This revision was automatically updated to reflect the committed changes.
Closed by commit rL245625: Understand absolute base addresses in
ProcessGDBRemote::GetLoadedModuleList. (authored by sas).
Changed prior to commit:
http://reviews.llvm.org/D12204?vs=32720&id=32757#toc
Repository:
rL LL
sas added a comment.
Sounds good. Thanks.
http://reviews.llvm.org/D12204
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tberghammer added a comment.
Yes, mine is effecting the ObjectFile plugins and the DynamicLoader plugins. I
will try to upload it tomorrow
http://reviews.llvm.org/D12204
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.or
sas added a comment.
Thanks for the reviews.
I'll take a look at your change when you upload it, Tamas. Do you think I can
commit this in the meantime?
http://reviews.llvm.org/D12204
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http:/
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks fine.
http://reviews.llvm.org/D12204
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
tberghammer added a subscriber: tberghammer.
tberghammer added a comment.
Looks good to me, but I don't know too much about the Windows stuff. I have a
pending CL what will fix several issues related to absolute base addresses in
the DynamicLoader. If it is something what is required on Windows
sas created this revision.
sas added reviewers: clayborg, zturner, ADodds.
sas added a subscriber: lldb-commits.
This is useful when dealing with Windows remote that use only the
qXfer:libraries command which returns absolute base addresses, as
opposed to qXfer:libraries-svr4 which returns relativ
