[Lldb-commits] [PATCH] D122041: [llvm][utils] Fix llvm::Optional summary provider

aprantl added a comment. In D122041#3405821 , @kastiglione wrote: >> There's some CMake trickery > > Can you shed some more light on this? Am I understanding right: these > formatters are llvm, but the test would be in lldb? It seems weird that >

[Lldb-commits] [PATCH] D122041: [llvm][utils] Fix llvm::Optional summary provider

kastiglione added a comment. > There's some CMake trickery Can you shed some more light on this? Am I understanding right: these formatters are llvm, but the test would be in lldb? It seems weird that something in llvm/ would only have tests in lldb/. Would it be bad to move this file into

[Lldb-commits] [PATCH] D122041: [llvm][utils] Fix llvm::Optional summary provider

aprantl added a comment. We don't at the moment. We could add a test to the LLDB testsuite that compiles a test program against Support. There's some CMake trickery necessary for this, which is probably why we've shied away from it thus far. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D122041: [llvm][utils] Fix llvm::Optional summary provider

shafik added a comment. Do we have any tests for these? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122041/new/ https://reviews.llvm.org/D122041 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D122041: [llvm][utils] Fix llvm::Optional summary provider

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG826bdf51ff31: [lldb] Fix llvm::Optional summary provider (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D122041: [llvm][utils] Fix llvm::Optional summary provider

kastiglione created this revision. kastiglione added reviewers: jingham, aprantl. kastiglione added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: