[Lldb-commits] [PATCH] D122093: [trace][intelpt] Added total memory usage by decoded trace

This revision was automatically updated to reflect the committed changes. Closed by commit rG37a466dd72b0: [trace][intelpt] Added total memory usage by decoded trace (authored by zrthxn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122093/new/

[Lldb-commits] [PATCH] D122093: [trace][intelpt] Added total memory usage by decoded trace

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122093/new/ https://reviews.llvm.org/D122093

[Lldb-commits] [PATCH] D122093: [trace][intelpt] Added total memory usage by decoded trace

zrthxn updated this revision to Diff 416826. zrthxn added a comment. Ingore errored instructions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122093/new/ https://reviews.llvm.org/D122093 Files:

[Lldb-commits] [PATCH] D122093: [trace][intelpt] Added total memory usage by decoded trace

wallace requested changes to this revision. wallace added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.cpp:123-130 + size_t non_err_instruction_count = 0; + for (const IntelPTInstruction :

[Lldb-commits] [PATCH] D122093: [trace][intelpt] Added total memory usage by decoded trace

zrthxn updated this revision to Diff 416825. zrthxn marked an inline comment as done. zrthxn added a comment. Cosmetic and minor changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122093/new/ https://reviews.llvm.org/D122093 Files:

[Lldb-commits] [PATCH] D122093: [trace][intelpt] Added total memory usage by decoded trace

zrthxn marked 4 inline comments as done. zrthxn added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp:119 + s.Printf(" Total approximate memory usage: %0.2lf KiB\n", + (float)mem_used / 1024); return; wallace

[Lldb-commits] [PATCH] D122093: [trace][intelpt] Added total memory usage by decoded trace

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. just some few remaining nits Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.h:85 + + /// Get the size in bytes of non-error instance of this

[Lldb-commits] [PATCH] D122093: [trace][intelpt] Added total memory usage by decoded trace

zrthxn updated this revision to Diff 416797. zrthxn added a comment. Changed to KiB and fixed how caclulation is done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122093/new/ https://reviews.llvm.org/D122093 Files:

[Lldb-commits] [PATCH] D122093: [trace][intelpt] Added total memory usage by decoded trace

wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.cpp:121-126 + size_t total = sizeof(m_raw_trace_size); + + for (const IntelPTInstruction : m_instructions) +total += ins.GetMemoryUsage(); + + return total;

[Lldb-commits] [PATCH] D122093: [trace][intelpt] Added total memory usage by decoded trace

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. Pretty nice! just some details i've noticed when reading your diff and good to go Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.cpp:121-126 +

[Lldb-commits] [PATCH] D122093: [trace][intelpt] Added total memory usage by decoded trace

zrthxn updated this revision to Diff 416765. zrthxn added a comment. Fixed trace info test for this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122093/new/ https://reviews.llvm.org/D122093 Files:

[Lldb-commits] [PATCH] D122093: [trace][intelpt] Added total memory usage by decoded trace

zrthxn updated this revision to Diff 416764. zrthxn added a comment. Clean up, works fine now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122093/new/ https://reviews.llvm.org/D122093 Files: lldb/source/Plugins/Trace/intel-pt/DecodedThread.cpp

[Lldb-commits] [PATCH] D122093: [trace][intelpt] Added total memory usage by decoded trace

zrthxn created this revision. zrthxn added reviewers: wallace, jj10306. Herald added a project: All. zrthxn requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This fails currently but the basics are there Repository: rG LLVM Github