This revision was automatically updated to reflect the committed changes.
Closed by commit rL245708: Implement handling of `library:` keys in thread stop
replies. (authored by sas).
Changed prior to commit:
http://reviews.llvm.org/D12218?vs=32766&id=32835#toc
Repository:
rL LLVM
http://revi
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D12218
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
tberghammer resigned from this revision.
tberghammer removed a reviewer: tberghammer.
tberghammer added a comment.
I leave this review to the others as I have no idea about how library loading
works on Windows. (On Linux/Android we use a breakpoint on a special symbol
exposed by the linker)
ht
sas updated this revision to Diff 32766.
sas added a comment.
Fix bug with bool comparison.
http://reviews.llvm.org/D12218
Files:
source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
Index: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
=
sas created this revision.
sas added reviewers: clayborg, zturner, tberghammer.
sas added a subscriber: lldb-commits.
When a windows remote stops because of a DLL load/unload, the debug server
sends a stop reply packet that contains a `library` key with any value (usually
just `library:1`). This i
