[Lldb-commits] [PATCH] D123202: [lldb] Fix detecting warning options for GCC

2022-04-06 Thread Martin Storsjö via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe546bbfda0ab: [lldb] Fix detecting warning options for GCC (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123202/new/

[Lldb-commits] [PATCH] D123202: [lldb] Fix detecting warning options for GCC

2022-04-06 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. Cool, I learned something new today. Thanks for adding that comment! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123202/new/ https://reviews.llvm.org/D123202 ___

[Lldb-commits] [PATCH] D123202: [lldb] Fix detecting warning options for GCC

2022-04-06 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. This is great. I've been bothered by this for quite a while, but I didn't realize the fix is that easy. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D123202: [lldb] Fix detecting warning options for GCC

2022-04-06 Thread Martin Storsjö via Phabricator via lldb-commits
mstorsjo created this revision. mstorsjo added a reviewer: labath. Herald added a subscriber: mgorny. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: LLDB. If testing for a warning option like -Wno- with GCC, GCC won't print any diagnostic at all,