This revision was automatically updated to reflect the committed changes.
Closed by commit rGb809c4cdb70a: [lldb] Add FixAnyAddress to ABI plugins
(authored by DavidSpickett).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124000/new/
JDevlieghere accepted this revision.
JDevlieghere added a comment.
Yes, this makes a lot of sense to me. Thanks for taking care of this. LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124000/new/
https://reviews.llvm.org/D124000
omjavaid accepted this revision.
omjavaid added a comment.
This revision is now accepted and ready to land.
Looks good to me.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124000/new/
https://reviews.llvm.org/D124000
DavidSpickett added reviewers: omjavaid, JDevlieghere.
DavidSpickett added a subscriber: JDevlieghere.
DavidSpickett added a comment.
This comes from https://reviews.llvm.org/D118794 on the subject of whether it's
ok to just pick one of fixcode/fixdata and assume it'll work.
Of all the uses of
DavidSpickett created this revision.
Herald added a subscriber: kristof.beyls.
Herald added a project: All.
DavidSpickett requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
FixAnyAddress is to be used when we don't know or don't care
whether
