[Lldb-commits] [PATCH] D124471: Disable symbol on-demand feature for Windows

2022-04-27 Thread jeffrey tan via Phabricator via lldb-commits
yinghuitan added a comment. @labath, that's a good point. If I remember correctly, exported function symbols will be included in Windows COFF export address table (which I assume will be parsed by lldb symtab). So in theory, if we change the tests (or add new tests) to set symbolic function bre

[Lldb-commits] [PATCH] D124471: Disable symbol on-demand feature for Windows

2022-04-27 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. FWIW, I don't think that this feature, as it is implemented right now, has any chance of working on windows. Windows does not have the equivalent of .symtab (only .dynsym), so we cannot use that as a poor man's debug info substitute -- the debug info is either there -- o

[Lldb-commits] [PATCH] D124471: Disable symbol on-demand feature for Windows

2022-04-26 Thread jeffrey tan via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd738d4717f6d: Disable symbol on-demand feature for Windows (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124471/new/ https://revie

[Lldb-commits] [PATCH] D124471: Disable symbol on-demand feature for Windows

2022-04-26 Thread jeffrey tan via Phabricator via lldb-commits
yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, JDevlieghere, jdoerfert, DavidSpickett. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Symbol on-demand featu