[Lldb-commits] [PATCH] D124573: [trace][intelpt] Support system-wide tracing [1] - Add a method for accessing the list of logical core ids

wallace added a comment. thanks for your review :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124573/new/ https://reviews.llvm.org/D124573 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D124573: [trace][intelpt] Support system-wide tracing [1] - Add a method for accessing the list of logical core ids

jj10306 added a comment. Much cleaner now, thanks for separating out the procfs logic  Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124573/new/ https://reviews.llvm.org/D124573 ___ lldb-commits

[Lldb-commits] [PATCH] D124573: [trace][intelpt] Support system-wide tracing [1] - Add a method for accessing the list of logical core ids

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5de0a3e9da72: [trace][intelpt] Support system-wide tracing [1] - Add a method for accessing… (authored by Walter Erquinigo wall...@fb.com).

[Lldb-commits] [PATCH] D124573: [trace][intelpt] Support system-wide tracing [1] - Add a method for accessing the list of logical core ids

wallace updated this revision to Diff 426424. wallace added a comment. final nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124573/new/ https://reviews.llvm.org/D124573 Files: lldb/docs/lldb-gdb-remote.txt

[Lldb-commits] [PATCH] D124573: [trace][intelpt] Support system-wide tracing [1] - Add a method for accessing the list of logical core ids

wallace updated this revision to Diff 426422. wallace added a comment. Herald added a subscriber: mgorny. move procfs functions to Procfs.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124573/new/ https://reviews.llvm.org/D124573 Files:

[Lldb-commits] [PATCH] D124573: [trace][intelpt] Support system-wide tracing [1] - Add a method for accessing the list of logical core ids

wallace added inline comments. Comment at: lldb/unittests/Process/Linux/PerfTests.cpp:53 +TEST(Perf, HardcodedLogicalCoreIDs) { + Expected> core_ids = jj10306 wrote: > Not directly related to this diff, but I just realized the proc fs parsing > logic doesn't

[Lldb-commits] [PATCH] D124573: [trace][intelpt] Support system-wide tracing [1] - Add a method for accessing the list of logical core ids

jj10306 accepted this revision. jj10306 added inline comments. Comment at: lldb/unittests/Process/Linux/PerfTests.cpp:53 +TEST(Perf, HardcodedLogicalCoreIDs) { + Expected> core_ids = Not directly related to this diff, but I just realized the proc fs parsing

[Lldb-commits] [PATCH] D124573: [trace][intelpt] Support system-wide tracing [1] - Add a method for accessing the list of logical core ids

wallace updated this revision to Diff 425936. wallace added a comment. I made a mistake and I included the second of two commits. This update contains all the code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124573/new/

[Lldb-commits] [PATCH] D124573: [trace][intelpt] Support system-wide tracing [1] - Add a method for accessing the list of logical core ids

wallace added inline comments. Comment at: lldb/include/lldb/Utility/TraceIntelPTGDBRemotePackets.h:22 +// List of data kinds used by jLLDBGetState and jLLDBGetBinaryData. +struct IntelPTDataKinds { + static const char *kProcFsCpuInfo; jj10306 wrote: > why not

[Lldb-commits] [PATCH] D124573: [trace][intelpt] Support system-wide tracing [1] - Add a method for accessing the list of logical core ids

jj10306 added inline comments. Comment at: lldb/include/lldb/Utility/TraceIntelPTGDBRemotePackets.h:22 +// List of data kinds used by jLLDBGetState and jLLDBGetBinaryData. +struct IntelPTDataKinds { + static const char *kProcFsCpuInfo; why not use an enum here?

[Lldb-commits] [PATCH] D124573: [trace][intelpt] Support system-wide tracing [1] - Add a method for accessing the list of logical core ids

wallace created this revision. wallace added a reviewer: jj10306. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In order to open perf events per core, we need to first get the list of core ids