This revision was automatically updated to reflect the committed changes.
Closed by commit rGb8d1776fc58d: [trace][intelpt] Support system-wide tracing
[2] - Add a dummy --per-core… (authored by Walter Erquinigo
wall...@fb.com).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
wallace added inline comments.
Comment at:
lldb/source/Plugins/Trace/intel-pt/CommandObjectTraceStartIntelPT.cpp:66
OptionParsingStarting(ExecutionContext *execution_context) {
- m_thread_buffer_size = kDefaultThreadBufferSize;
+ m_trace_buffer_size =
wallace added inline comments.
Comment at: lldb/docs/lldb-gdb-remote.txt:369
+//
+// /* process tracing only */
// "processBufferSizeLimit": ,
jj10306 wrote:
> Why do we only want this option for process tracing?
> Per cpu tracing collects all trace
jj10306 requested changes to this revision.
jj10306 added a comment.
This revision now requires changes to proceed.
Before doing a complete review can you provide clarity on the decision to only
support perCore for process wide (see my inline comment with my
thoughts/questions)? Understanding
wallace updated this revision to Diff 425917.
wallace added a comment.
nit
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124640/new/
https://reviews.llvm.org/D124640
Files:
lldb/docs/lldb-gdb-remote.txt
wallace created this revision.
wallace added a reviewer: jj10306.
Herald added a project: All.
wallace requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
This updates the documentation of the gdb-remote protocol, as well as the help
