[Lldb-commits] [PATCH] D124814: Fix debugserver translation check

This revision was automatically updated to reflect the committed changes. Closed by commit rGeb3136f022b3: Fix debugserver translation check (authored by aperez). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124814/new/

[Lldb-commits] [PATCH] D124814: Fix debugserver translation check

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM. I see how your workflow is set up. Yeah, you return an error if someone tries to run debugserver in translation (and the inferior isn't x86_64) - that's what we need to

[Lldb-commits] [PATCH] D124814: Fix debugserver translation check

aperez added a comment. In D124814#3487179 , @jasonmolenda wrote: > Ah, I see what you're doing. You've got a shell running x86_64 or something > (maybe started lldb as x86_64) so everything that is spawned from that is > x86_64 -- debugserver and

[Lldb-commits] [PATCH] D124814: Fix debugserver translation check

jasonmolenda added a comment. (tbh every case I've seen, it's someone who checked "Run in Rosetta" on the Xcode.app bundle with Finder, and are running their entire IDE as x86_64) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124814/new/

[Lldb-commits] [PATCH] D124814: Fix debugserver translation check

jasonmolenda added a comment. Ah, I see what you're doing. You've got a shell running x86_64 or something (maybe started lldb as x86_64) so everything that is spawned from that is x86_64 -- debugserver and the inferior process -- and so you hit this. let me look more closely later tonight,

[Lldb-commits] [PATCH] D124814: Fix debugserver translation check

aperez created this revision. Herald added subscribers: pengfei, kristof.beyls. Herald added a project: All. aperez edited the summary of this revision. aperez added a project: LLDB. Herald added a subscriber: JDevlieghere. aperez added reviewers: clayborg, jasonmolenda. aperez published this