[Lldb-commits] [PATCH] D125437: [lldb/API] Add SBCompileUnit::GetIndexForLineEntry method to SB API

JDevlieghere added inline comments. Comment at: lldb/include/lldb/API/SBCompileUnit.h:37 + uint32_t GetIndexForLineEntry(lldb::SBLineEntry _entry, +bool exact = false) const; mib wrote: > JDevlieghere wrote: > > How's this

[Lldb-commits] [PATCH] D125437: [lldb/API] Add SBCompileUnit::GetIndexForLineEntry method to SB API

mib closed this revision. mib marked an inline comment as done. mib added a comment. Landed in a6926d576131c9ad849fef6f1d43134caab5025e Comment at: lldb/include/lldb/API/SBCompileUnit.h:37 + uint32_t

[Lldb-commits] [PATCH] D125437: [lldb/API] Add SBCompileUnit::GetIndexForLineEntry method to SB API

JDevlieghere added inline comments. Comment at: lldb/include/lldb/API/SBCompileUnit.h:37 + uint32_t GetIndexForLineEntry(lldb::SBLineEntry _entry, +bool exact = false) const; How's this different from `FindLineEntryIndex`? In

[Lldb-commits] [PATCH] D125437: [lldb/API] Add SBCompileUnit::GetIndexForLineEntry method to SB API

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125437/new/ https://reviews.llvm.org/D125437 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D125437: [lldb/API] Add SBCompileUnit::GetIndexForLineEntry method to SB API

mib added a comment. Address @jingham feedbacks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125437/new/ https://reviews.llvm.org/D125437 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D125437: [lldb/API] Add SBCompileUnit::GetIndexForLineEntry method to SB API

mib updated this revision to Diff 428841. mib added a comment. I forgot to add the test in the previous diffs --' CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125437/new/ https://reviews.llvm.org/D125437 Files: lldb/bindings/interface/SBCompileUnit.i

[Lldb-commits] [PATCH] D125437: [lldb/API] Add SBCompileUnit::GetIndexForLineEntry method to SB API

mib updated this revision to Diff 428829. mib added a comment. Addressed @jingham comments: - Use early returns - Remove `LineEntry::Compare` call since it's already handled by `CompileUnit::FindLineEntry` - Add docstring CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125437/new/

[Lldb-commits] [PATCH] D125437: [lldb/API] Add SBCompileUnit::GetIndexForLineEntry method to SB API

mib added inline comments. Comment at: lldb/source/API/SBCompileUnit.cpp:94 + +if (!exact || +(exact && !LineEntry::Compare(line_entry.ref(), found_line_entry))) jingham wrote: > Why do you have to do this Compare? You already passed exact to >

[Lldb-commits] [PATCH] D125437: [lldb/API] Add SBCompileUnit::GetIndexForLineEntry method to SB API

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. This needs a doctoring for the API and some test. Comment at: lldb/source/API/SBCompileUnit.cpp:86 + uint32_t index = UINT32_MAX; + if (m_opaque_ptr &&

[Lldb-commits] [PATCH] D125437: [lldb/API] Add SBCompileUnit::GetIndexForLineEntry method to SB API

mib created this revision. mib added reviewers: jingham, JDevlieghere. mib added a project: LLDB. Herald added a subscriber: arphaman. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch adds a new `GetIndexForLineEntry` method