This revision was automatically updated to reflect the committed changes.
Closed by commit rGa8bec6117998: [lldb] Fix that empty target.run-args are not
actually used when launching… (authored by teemperor).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
jingham accepted this revision.
jingham added a comment.
GetPropertyAtIndexAsArg isn't actually documented, so we don't know what the
original intent for the return value was. But in almost all the cases where we
look up a property using this function, when we use the enum directly we
discard
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM. Passes the test suite on macOS.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126057/new/
https://reviews.llvm.org/D126057
teemperor added a comment.
Don't have access to a macOS machine that can run the tests, so maybe someone
should give this a spin before landing :)
Comment at: lldb/source/Interpreter/OptionValueProperties.cpp:257
const OptionValueArray *array = value->GetAsArray();
- if
teemperor created this revision.
teemperor added reviewers: JDevlieghere, kastiglione.
teemperor added a project: LLDB.
Herald added a project: All.
teemperor requested review of this revision.
Herald added a subscriber: lldb-commits.
`GetPropertyAtIndexAsArgs` returns true on success and false
