sas closed this revision.
sas added a comment.
Committed as r248007.
Repository:
rL LLVM
http://reviews.llvm.org/D12750
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
brucem accepted this revision.
brucem added a comment.
This revision is now accepted and ready to land.
We can do that other part later ... we don't have to require newer cmake to do
it, just provide our own file that does something similar until we update to
newer cmake.
Repository:
rL LLVM
krytarowski added a comment.
In http://reviews.llvm.org/D12750#244435, @sas wrote:
> @brucem, not sure exactly what way forward you are suggesting. LLDB build
> system supports cmake 2.8.12 and up, so we can't use FindBacktrace unless we
> bump that to 3.0. Are we recommending we do that?
Can
sas accepted this revision.
sas added a comment.
I'm fine with this patch the way it is. Unless @brucem refuses, I'll submit it.
Improving cmake checks can be dealt with later on.
Repository:
rL LLVM
http://reviews.llvm.org/D12750
___
lldb-commi
krytarowski added a comment.
In http://reviews.llvm.org/D12750#244435, @sas wrote:
> @brucem, not sure exactly what way forward you are suggesting. LLDB build
> system supports cmake 2.8.12 and up, so we can't use FindBacktrace unless we
> bump that to 3.0. Are we recommending we do that?
Can
sas added a comment.
@brucem, not sure exactly what way forward you are suggesting. LLDB build
system supports cmake 2.8.12 and up, so we can't use FindBacktrace unless we
bump that to 3.0. Are we recommending we do that?
Repository:
rL LLVM
http://reviews.llvm.org/D12750
___
brucem added a subscriber: brucem.
brucem requested changes to this revision.
brucem added a reviewer: brucem.
This revision now requires changes to proceed.
Comment at: cmake/LLDBDependencies.cmake:152
@@ -153,1 +151,3 @@
+# On FreeBSD/NetBSD backtrace() is provided by libexecinf
krytarowski updated this revision to Diff 34490.
krytarowski added a comment.
typo
Repository:
rL LLVM
http://reviews.llvm.org/D12750
Files:
cmake/LLDBDependencies.cmake
Index: cmake/LLDBDependencies.cmake
===
--- cmake/LLDBD
sas added a subscriber: sas.
sas requested changes to this revision.
sas added a reviewer: sas.
This revision now requires changes to proceed.
Comment at: cmake/LLDBDependencies.cmake:152
@@ -153,1 +151,3 @@
+# On FreeBSD/NetBSD backtrace() is provided by libexecinfo, not libc.
+i
krytarowski created this revision.
krytarowski added a reviewer: joerg.
krytarowski added a subscriber: lldb-commits.
krytarowski set the repository for this revision to rL LLVM.
FreeBSD and NetBSD share the same library execinfo.
Repository:
rL LLVM
http://reviews.llvm.org/D12750
Files:
cm
10 matches
Mail list logo