[Lldb-commits] [PATCH] D127667: [lldb] [llgs] Implement the vKill packet

2022-06-24 Thread Michał Górny via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc18784ba330a: [lldb] [llgs] Implement the vKill packet (authored by mgorny). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D127667: [lldb] [llgs] Implement the vKill packet

2022-06-24 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Yeah, the pre-exit event makes this somewhat tricky. Let's stick with this then. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127667/new/ https://reviews.llvm.org/D127667

[Lldb-commits] [PATCH] D127667: [lldb] [llgs] Implement the vKill packet

2022-06-23 Thread Michał Górny via Phabricator via lldb-commits
mgorny added a comment. In D127667#3603910 , @labath wrote: > Do we need the kill command to be asynchronous (return before the process > actually dies) for anything. Could we just make it synchronous instead (call > wait inside the process plugin, and

[Lldb-commits] [PATCH] D127667: [lldb] [llgs] Implement the vKill packet

2022-06-23 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Do we need the kill command to be asynchronous (return before the process actually dies) for anything. Could we just make it synchronous instead (call wait inside the process plugin, and return the wait result)? CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D127667: [lldb] [llgs] Implement the vKill packet

2022-06-21 Thread Michał Górny via Phabricator via lldb-commits
mgorny updated this revision to Diff 438819. mgorny added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127667/new/ https://reviews.llvm.org/D127667 Files: lldb/include/lldb/Utility/StringExtractorGDBRemote.h

[Lldb-commits] [PATCH] D127667: [lldb] [llgs] Implement the vKill packet

2022-06-21 Thread Michał Górny via Phabricator via lldb-commits
mgorny updated this revision to Diff 438706. mgorny added a comment. Rebase and update for changes in D127500 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127667/new/ https://reviews.llvm.org/D127667 Files: