[Lldb-commits] [PATCH] D128410: [lldb] Add a testcase for nested exceptions on Windows

2022-06-28 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D128410#3609185 , @mstorsjo wrote: > In D128410#3608190 , @labath wrote: > >> In D128410#3604927 , @alvinhochun >> wrote: >> >>> It may be

[Lldb-commits] [PATCH] D128410: [lldb] Add a testcase for nested exceptions on Windows

2022-06-24 Thread Martin Storsjö via Phabricator via lldb-commits
mstorsjo added a comment. In D128410#3608190 , @labath wrote: > In D128410#3604927 , @alvinhochun > wrote: > >> It may be possible to stuff a pointer to an `EXCEPTION_RECORD` into another >> `EXCEPTION_RECORD`

[Lldb-commits] [PATCH] D128410: [lldb] Add a testcase for nested exceptions on Windows

2022-06-24 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D128410#3604927 , @alvinhochun wrote: > It may be possible to stuff a pointer to an `EXCEPTION_RECORD` into another > `EXCEPTION_RECORD` and use `RtlRaiseException` to generate the exception, but > you'll have to test how it

[Lldb-commits] [PATCH] D128410: [lldb] Add a testcase for nested exceptions on Windows

2022-06-23 Thread Alvin Wong via Phabricator via lldb-commits
alvinhochun added inline comments. Comment at: lldb/test/Shell/Process/Windows/wndproc_exception.cpp:7 +// RUN: %clangxx_host -o %t.exe -luser32 -v -- %s +// RUN: %lldb -f %t.exe -o "run" + alvinhochun wrote: > mstorsjo wrote: > > mstorsjo wrote: > > > labath

[Lldb-commits] [PATCH] D128410: [lldb] Add a testcase for nested exceptions on Windows

2022-06-23 Thread Alvin Wong via Phabricator via lldb-commits
alvinhochun added inline comments. Comment at: lldb/test/Shell/Process/Windows/wndproc_exception.cpp:7 +// RUN: %clangxx_host -o %t.exe -luser32 -v -- %s +// RUN: %lldb -f %t.exe -o "run" + mstorsjo wrote: > mstorsjo wrote: > > labath wrote: > > > Is there

[Lldb-commits] [PATCH] D128410: [lldb] Add a testcase for nested exceptions on Windows

2022-06-23 Thread Alvin Wong via Phabricator via lldb-commits
alvinhochun added a comment. It may be possible to stuff a pointer to an `EXCEPTION_RECORD` into another `EXCEPTION_RECORD` and use `RtlRaiseException` to generate the exception, but you'll have to test how it actually works. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D128410: [lldb] Add a testcase for nested exceptions on Windows

2022-06-23 Thread Martin Storsjö via Phabricator via lldb-commits
mstorsjo added a comment. In D128410#3604083 , @mstorsjo wrote: > I'm not all that familiar with exactly what happens in these APIs here that > makes this a nested exception and what other non-GUI APIs would produce the > same effect. Maybe any API

[Lldb-commits] [PATCH] D128410: [lldb] Add a testcase for nested exceptions on Windows

2022-06-23 Thread Martin Storsjö via Phabricator via lldb-commits
mstorsjo added inline comments. Comment at: lldb/test/Shell/Process/Windows/wndproc_exception.cpp:7 +// RUN: %clangxx_host -o %t.exe -luser32 -v -- %s +// RUN: %lldb -f %t.exe -o "run" + mstorsjo wrote: > labath wrote: > > Is there something reasonable we could

[Lldb-commits] [PATCH] D128410: [lldb] Add a testcase for nested exceptions on Windows

2022-06-23 Thread Martin Storsjö via Phabricator via lldb-commits
mstorsjo added a subscriber: stella.stamenova. mstorsjo added a comment. In D128410#3604075 , @labath wrote: > In D128410#3604066 , @mstorsjo > wrote: > >> For this testcase to work, it needs to be able to open

[Lldb-commits] [PATCH] D128410: [lldb] Add a testcase for nested exceptions on Windows

2022-06-23 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D128410#3604066 , @mstorsjo wrote: > For this testcase to work, it needs to be able to open a window - so it can't > run entirely in headless mode. But I guess that a bunch of other tests in > LLDB also already do that, since

[Lldb-commits] [PATCH] D128410: [lldb] Add a testcase for nested exceptions on Windows

2022-06-23 Thread Martin Storsjö via Phabricator via lldb-commits
mstorsjo added a comment. Herald added a subscriber: JDevlieghere. For this testcase to work, it needs to be able to open a window - so it can't run entirely in headless mode. But I guess that a bunch of other tests in LLDB also already do that, since running the LLDB tests on Windows pops up a

[Lldb-commits] [PATCH] D128410: [lldb] Add a testcase for nested exceptions on Windows

2022-06-23 Thread Martin Storsjö via Phabricator via lldb-commits
mstorsjo created this revision. mstorsjo added reviewers: labath, alvinhochun, DavidSpickett. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: LLDB. This adds a testcase for 4d123783957e547009e55346bf3a8ae43a88fa14