This revision was automatically updated to reflect the committed changes.
Closed by commit rG695c22c84a36: [LLDB] Fix PDB/pointers.test for 32bit
Arm/Windows (authored by omjavaid).
Herald added a project: LLDB.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
mstorsjo accepted this revision.
mstorsjo added inline comments.
This revision is now accepted and ready to land.
Comment at: lldb/test/Shell/SymbolFile/PDB/pointers.test:2
REQUIRES: system-windows, msvc
RUN: %build --compiler=clang-cl --mode=compile --arch=32 --nodefaultlib
omjavaid added inline comments.
Comment at: lldb/test/Shell/SymbolFile/PDB/pointers.test:2
REQUIRES: system-windows, msvc
RUN: %build --compiler=clang-cl --mode=compile --arch=32 --nodefaultlib
--output=%T/PointerTypeTest.cpp.obj %S/Inputs/PointerTypeTest.cpp
RUN: %build
mstorsjo added a comment.
I presume this is ok - if the main intent of this test is to test handling of
pointers and the size thereof in PDBs.
Comment at: lldb/test/Shell/SymbolFile/PDB/pointers.test:2
REQUIRES: system-windows, msvc
RUN: %build --compiler=clang-cl
omjavaid added inline comments.
Comment at: lldb/test/Shell/SymbolFile/PDB/pointers.test:36
F: Variable{{.*}}, name = "this"
-F-SAME:(ST *), scope = parameter, location = {{.*}}, artificial
+F-SAME:(ST *), scope = parameter,{{( location = DW_OP.*,)?}} artificial
F:
omjavaid created this revision.
omjavaid added reviewers: mstorsjo, DavidSpickett.
Herald added subscribers: jsji, pengfei, kristof.beyls.
Herald added a project: All.
omjavaid requested review of this revision.
PDB/pointers.test was orignally written for 32bit x86 keeping in mind
__cdecl and
