ki.stfu added a comment.
i. e. +1 with @zturner
http://reviews.llvm.org/D12899
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner added a comment.
One possible solution is to make an lldb-all target.
http://reviews.llvm.org/D12899
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
From a high level, when we ask a build system to build the lldb executable, we
want that to mean "build me an lldb and anything it will use as part of its
normal operation."
If we did not build the lldb executable's expected components (as was the case
when I started
ki.stfu added a comment.
In http://reviews.llvm.org/D12899#248657, @tberghammer wrote:
> In http://reviews.llvm.org/D12899#248654, @ki.stfu wrote:
>
> > In http://reviews.llvm.org/D12899#248648, @zturner wrote:
> >
> > > One possible solution is to make an lldb-all target.
> >
> >
> > As I said,
ki.stfu added a comment.
In http://reviews.llvm.org/D12899#248648, @zturner wrote:
> One possible solution is to make an lldb-all target.
As I said, it would much better rather than changing lldb dependencies. But I'm
still not sure, do we really need something like lldb-all? Why we can't use
tfiala added a comment.
In http://reviews.llvm.org/D12899#248741, @ki.stfu wrote:
> In http://reviews.llvm.org/D12899#248657, @tberghammer wrote:
>
> > In http://reviews.llvm.org/D12899#248654, @ki.stfu wrote:
> >
> > > In http://reviews.llvm.org/D12899#248648, @zturner wrote:
> > >
> > > > One
tfiala created this revision.
tfiala added reviewers: labath, clayborg, emaste.
tfiala added a subscriber: lldb-commits.
Addresses:
* https://llvm.org/bugs/show_bug.cgi?id=24831: cmake + ninja: 'ninja lldb'
misses lib/python2.7 build dependency on Linux
*
tfiala added a comment.
@emaste, I'm adding you because I have no idea what the state of the *BSD world
is with regards to lldb-server. It looks like you might still use the native
process bits so lldb-server might not be interesting over there. If it is, we
can extend the "always add the
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks good, thanks for fixing this.
Comment at: tools/driver/CMakeLists.txt:13
@@ +12,3 @@
+ add_dependencies(lldb lldb-server)
+endif()
+
We should
tfiala added a comment.
> (These have already diverged as you are only doing this for Linux, but
> lldb-server is built on FreeBSD as well.)
Hi Bruce,
My primary goal was to make sure 'ninja lldb' builds the parts that are
necessary for lldb to run and be tested. Linux cannot debug a local
tfiala added a comment.
> Okay I'll make an adjustment to turn it on for Darwin and setting it based on
> a flag.
I'm going to do it slightly differently --- I'll set a flag in the modules
config that indicates if lldb *wants* lldb-server. The logic on whether to
build it or not should, as
tfiala added a comment.
In http://reviews.llvm.org/D12899#247098, @tfiala wrote:
> Adjustments to set indirect variable for whether lldb can use lldb-server.
> If so, then we'll add the dependency for lldb-server on lldb at the time we
> declare the lldb target.
Also adds lldb-server
tfiala added a comment.
> Yeah... it is starting to get a bit over-engineered. :)
It's all good :-)
http://reviews.llvm.org/D12899
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
tfiala marked 5 inline comments as done.
tfiala added a comment.
I think this covers everything.
http://reviews.llvm.org/D12899
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala updated this revision to Diff 34894.
tfiala added a comment.
Adds an orthogonal can-use-debugserver flag. Flips it on for Darwin.
I'm okay with the Darwin cmake build building both of those for the lldb target
since I want the consistency checks between the two running on Darwin.
tfiala added a comment.
I'll check this in if I don't hear boo in the next few minutes...
http://reviews.llvm.org/D12899
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
In http://reviews.llvm.org/D12899#247092, @emaste wrote:
> In http://reviews.llvm.org/D12899#246881, @tfiala wrote:
>
> > @emaste, I'm adding you because I have no idea what the state of the *BSD
> > world is with regards to lldb-server. It looks like you might still
17 matches
Mail list logo
