labath added a comment.
Committed as r247991. We can tweak this later if needed after Kamil's changes
go in.
Repository:
rL LLVM
http://reviews.llvm.org/D12900
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247991: Fix link failures when BUILD_SHARED_LIBS=ON.
(authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D12900?vs=35075&id=35082#toc
Repository:
rL LLVM
http://reviews.llvm.org/D
dsanders updated this revision to Diff 35075.
dsanders added a comment.
Pavel's suggestion to use LLDB_SYSTEM_LIBS works for me. Updated the patch.
http://reviews.llvm.org/D12900
Files:
tools/lldb-server/CMakeLists.txt
Index: tools/lldb-server/CMakeLists.txt
=
krytarowski added a subscriber: krytarowski.
krytarowski requested changes to this revision.
krytarowski added a reviewer: krytarowski.
This revision now requires changes to proceed.
Comment at: tools/lldb-server/CMakeLists.txt:40
@@ +39,3 @@
+ if (NOT LLDB_DISABLE_CURSES)
+t
labath added a subscriber: labath.
labath added a reviewer: labath.
labath added a comment.
Thanks for the patch.
LLDBDependencies.cmake sets LLDB_SYSTEM_LIBS to the list of libraries lldb
depends on. Could you check if it is not sufficient to add this to the list of
dependencies? I'd like to a
dsanders added a comment.
This patch does the trick for me but I'm not certain it's the right fix
overall. Could someone take a look?
http://reviews.llvm.org/D12900
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi
dsanders created this revision.
dsanders added a subscriber: lldb-commits.
http://reviews.llvm.org/D12900
Files:
tools/lldb-server/CMakeLists.txt
Index: tools/lldb-server/CMakeLists.txt
===
--- tools/lldb-server/CMakeLists.txt
+++
