Re: [Lldb-commits] [PATCH] D12971: Remove unused modules from module cache

2015-09-18 Thread Oleksiy Vyalov via lldb-commits
ovyalov closed this revision. ovyalov added a comment. Files: /lldb/trunk/include/lldb/Host/FileSystem.h /lldb/trunk/source/Host/posix/FileSystem.cpp /lldb/trunk/source/Host/windows/FileSystem.cpp /lldb/trunk/source/Utility/ModuleCache.cpp Users: ovyalov (Author)

[Lldb-commits] [PATCH] D12971: Remove unused modules from module cache

2015-09-18 Thread Oleksiy Vyalov via lldb-commits
ovyalov created this revision. ovyalov added reviewers: clayborg, zturner. ovyalov added a subscriber: lldb-commits. When putting a new module into module cache sysroot folder may contain existing hard link for an existing module with the same name but different build-id. Use hard link counter

Re: [Lldb-commits] [PATCH] D12971: Remove unused modules from module cache

2015-09-18 Thread Zachary Turner via lldb-commits
zturner added inline comments. Comment at: source/Host/windows/FileSystem.cpp:130 @@ +129,3 @@ +HANDLE file_handle = ::CreateFile(file_spec.GetCString(), + GENERIC_READ, + FILE_SHARE_READ,

Re: [Lldb-commits] [PATCH] D12971: Remove unused modules from module cache

2015-09-18 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Flow looks good, take care of Zachs issues and this is good to go. http://reviews.llvm.org/D12971 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D12971: Remove unused modules from module cache

2015-09-18 Thread Oleksiy Vyalov via lldb-commits
ovyalov updated this revision to Diff 35106. ovyalov added a comment. Replaced GENERIC_READ with FILE_READ_ATTRIBUTES when using ::CreateFile. http://reviews.llvm.org/D12971 Files: include/lldb/Host/FileSystem.h source/Host/posix/FileSystem.cpp source/Host/windows/FileSystem.cpp

Re: [Lldb-commits] [PATCH] D12971: Remove unused modules from module cache

2015-09-18 Thread Oleksiy Vyalov via lldb-commits
ovyalov added inline comments. Comment at: source/Host/windows/FileSystem.cpp:130 @@ +129,3 @@ +HANDLE file_handle = ::CreateFile(file_spec.GetCString(), + FILE_READ_ATTRIBUTES, + FILE_SHARE_READ,

Re: [Lldb-commits] [PATCH] D12971: Remove unused modules from module cache

2015-09-18 Thread Zachary Turner via lldb-commits
Ok, lgtm then On Fri, Sep 18, 2015 at 10:42 AM Oleksiy Vyalov wrote: > ovyalov added inline comments. > > > Comment at: source/Host/windows/FileSystem.cpp:130 > @@ +129,3 @@ > +HANDLE file_handle = ::CreateFile(file_spec.GetCString(), > +