Re: [Lldb-commits] [PATCH] D12977: LLDB MI addition for getting process stopped at first instruction right after launch via -exec-run

2015-09-29 Thread Kirill Lapshin via lldb-commits
KLapshin marked an inline comment as done. KLapshin added a comment. m_lldbResult usage has beed removed in ExecRun::Acknowledge() method, corresponding member removed from cmd class. Repository: rL LLVM http://reviews.llvm.org/D12977 ___

Re: [Lldb-commits] [PATCH] D12977: LLDB MI addition for getting process stopped at first instruction right after launch via -exec-run

2015-09-28 Thread Kirill Lapshin via lldb-commits
KLapshin marked an inline comment as done. KLapshin added a comment. Requested changes applied, updated patch uploaded. Comment at: tools/lldb-mi/MICmdCmdExec.h:58 @@ -57,2 +57,3 @@ bool Acknowledge() override; +bool ParseArgs() override; // From CMICmnBase

Re: [Lldb-commits] [PATCH] D12977: LLDB MI addition for getting process stopped at first instruction right after launch via -exec-run

2015-09-28 Thread Kirill Lapshin via lldb-commits
KLapshin updated the summary for this revision. KLapshin updated this revision to Diff 35865. Repository: rL LLVM http://reviews.llvm.org/D12977 Files: test/tools/lldb-mi/control/TestMiExec.py tools/lldb-mi/MICmdCmdExec.cpp tools/lldb-mi/MICmdCmdExec.h

Re: [Lldb-commits] [PATCH] D12977: LLDB MI addition for getting process stopped at first instruction right after launch via -exec-run

2015-09-26 Thread Kirill Lapshin via lldb-commits
KLapshin added a comment. @brucem, @enlight Is this patch is fine for you now ? Repository: rL LLVM http://reviews.llvm.org/D12977 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D12977: LLDB MI addition for getting process stopped at first instruction right after launch via -exec-run

2015-09-26 Thread Ilia K via lldb-commits
ki.stfu requested changes to this revision. ki.stfu added a comment. This revision now requires changes to proceed. Update the summary + a few inline comments below. Comment at: test/tools/lldb-mi/startup_options/TestMiStartupOptions.py:13-31 @@ -12,3 +12,21 @@

Re: [Lldb-commits] [PATCH] D12977: LLDB MI addition for getting process stopped at first instruction right after launch via -exec-run

2015-09-25 Thread Kirill Lapshin via lldb-commits
KLapshin updated the summary for this revision. KLapshin updated this revision to Diff 35740. KLapshin added a comment. Patch reworked for suggested "-exec-run --start" manner, no "CLI" interpreter use and check if --start option supported via -list-features. Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D12977: LLDB MI addition for getting process stopped at first instruction right after launch via -exec-run

2015-09-25 Thread Dawn Perchik via lldb-commits
dawn accepted this revision. dawn added a comment. lgtm. Much improved. Comment at: tools/lldb-mi/MICmdCmdSupportList.cpp:78 @@ +77,3 @@ +CMICmnMIValueList miValueList(true); +// Some of features may depend on host or/and target, decide what to add below +

Re: [Lldb-commits] [PATCH] D12977: LLDB MI addition for getting process stopped at first instruction right after launch via -exec-run

2015-09-25 Thread Kirill Lapshin via lldb-commits
KLapshin marked an inline comment as done. KLapshin added a comment. "CLI" intepreter not used in ExecRun handler in reworked patch. Repository: rL LLVM http://reviews.llvm.org/D12977 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D12977: LLDB MI addition for getting process stopped at first instruction right after launch via -exec-run

2015-09-21 Thread Kirill Lapshin via lldb-commits
KLapshin added a comment. In http://reviews.llvm.org/D12977#249437, @enlight wrote: > According to the GDB-MI spec the exec-run > > command already has a **start** option. Support for the

Re: [Lldb-commits] [PATCH] D12977: LLDB MI addition for getting process stopped at first instruction right after launch via -exec-run

2015-09-21 Thread Kirill Lapshin via lldb-commits
KLapshin added inline comments. Comment at: tools/lldb-mi/MICmdCmdExec.cpp:92 @@ +91,3 @@ +const char *pCmd = bProcessMustStopAtEntry ? "process launch -s" : "process launch"; +const lldb::ReturnStatus rtn =

Re: [Lldb-commits] [PATCH] D12977: LLDB MI addition for getting process stopped at first instruction right after launch via -exec-run

2015-09-20 Thread Bruce Mitchener via lldb-commits
brucem added a subscriber: brucem. brucem requested changes to this revision. brucem added a reviewer: brucem. brucem added a comment. This revision now requires changes to proceed. I think that enlight is correct in his comments and that this patch should be revised. Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D12977: LLDB MI addition for getting process stopped at first instruction right after launch via -exec-run

2015-09-19 Thread Vadim Macagon via lldb-commits
enlight added a subscriber: enlight. enlight added a comment. According to the GDB-MI spec the exec-run command already has a **start** option. Support for the **start** option can be

Re: [Lldb-commits] [PATCH] D12977: LLDB MI addition for getting process stopped at first instruction right after launch via -exec-run

2015-09-18 Thread Dawn Perchik via lldb-commits
dawn added a comment. lgtm, but Ilia and Abid are more familiar with lldb-mi - please wait for their review. Repository: rL LLVM http://reviews.llvm.org/D12977 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D12977: LLDB MI addition for getting process stopped at first instruction right after launch via -exec-run

2015-09-18 Thread Kirill Lapshin via lldb-commits
KLapshin updated the summary for this revision. KLapshin removed rL LLVM as the repository for this revision. KLapshin updated this revision to Diff 35109. KLapshin added a comment. Minor initial diff cleanup. http://reviews.llvm.org/D12977 Files: test/tools/lldb-mi/TestMiGdbSetShow.py