This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
fixathon marked an inline comment as done.
Closed by commit rG06ff46d2d77f: [LLDB][NFC] Fix suspicious bitwise expression
in PrintBTEntry()
DavidSpickett added inline comments.
Comment at: lldb/tools/intel-features/intel-mpx/cli-wrapper-mpxtable.cpp:66
- if ((lbound == one_cmpl64 || one_cmpl32) && ubound == 0) {
result.Printf("Null bounds on map: pointer value = 0x%" PRIu64 "\n",
value);
DavidSpickett added inline comments.
Comment at: lldb/tools/intel-features/intel-mpx/cli-wrapper-mpxtable.cpp:66
- if ((lbound == one_cmpl64 || one_cmpl32) && ubound == 0) {
result.Printf("Null bounds on map: pointer value = 0x%" PRIu64 "\n",
value);
hawkinsw added inline comments.
Comment at: lldb/tools/intel-features/intel-mpx/cli-wrapper-mpxtable.cpp:66
- if ((lbound == one_cmpl64 || one_cmpl32) && ubound == 0) {
result.Printf("Null bounds on map: pointer value = 0x%" PRIu64 "\n",
value);
DavidSpickett added a comment.
The original change was https://reviews.llvm.org/D29078. Are you able to run
the tests with this applied?
Comment at: lldb/tools/intel-features/intel-mpx/cli-wrapper-mpxtable.cpp:66
- if ((lbound == one_cmpl64 || one_cmpl32) && ubound == 0) {
hawkinsw added inline comments.
Comment at: lldb/tools/intel-features/intel-mpx/cli-wrapper-mpxtable.cpp:66
- if ((lbound == one_cmpl64 || one_cmpl32) && ubound == 0) {
result.Printf("Null bounds on map: pointer value = 0x%" PRIu64 "\n",
value);
fixathon created this revision.
fixathon added reviewers: clayborg, JDevlieghere, DavidSpickett, jasonmolenda.
Herald added a project: All.
fixathon requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Current application of bitwise-OR to a
