[Lldb-commits] [PATCH] D13158: Allow to construct CMIUtilString using std::string directly (MI)

2015-09-25 Thread Ilia K via lldb-commits
ki.stfu created this revision. ki.stfu added reviewers: abidh, brucem. ki.stfu added subscribers: abidh, brucem, lldb-commits. Allow to construct CMIUtilString using std::string directly (MI) This patch cleans up lldb-mi code, and serves to simplify the following case: ``` std::string

Re: [Lldb-commits] [PATCH] D13158: Allow to construct CMIUtilString using std::string directly (MI)

2015-09-25 Thread Ilia K via lldb-commits
ki.stfu added inline comments. Comment at: tools/lldb-mi/MICmdInterpreter.cpp:166 @@ -165,3 +165,3 @@ m_miCmdData.strMiCmdToken = strNum.c_str(); } brucem wrote: > Can this one be changed too? Sure. http://reviews.llvm.org/D13158

Re: [Lldb-commits] [PATCH] D13158: Allow to construct CMIUtilString using std::string directly (MI)

2015-09-25 Thread Ilia K via lldb-commits
ki.stfu updated this revision to Diff 35703. ki.stfu added a comment. A little fix as @brucem requested; Remove CMIUtilString(const char *const *vpData) and CMIUtilString(const char *vpData, size_t nLen) ctors; Cleanup CMIUtilString::operator=(const std::string )

Re: [Lldb-commits] [PATCH] D13158: Allow to construct CMIUtilString using std::string directly (MI)

2015-09-25 Thread Bruce Mitchener via lldb-commits
brucem added inline comments. Comment at: tools/lldb-mi/MICmdInterpreter.cpp:166 @@ -165,3 +165,3 @@ m_miCmdData.strMiCmdToken = strNum.c_str(); } Can this one be changed too? http://reviews.llvm.org/D13158