Re: [Lldb-commits] [PATCH] D13202: [LLDB] Fix display of value of a vector variables in watchpoint operations

mohit.bhakkad added a comment. @loladiro @zturner Thanks for pointing this out, fixed it in http://reviews.llvm.org/rL249897 Repository: rL LLVM http://reviews.llvm.org/D13202 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D13202: [LLDB] Fix display of value of a vector variables in watchpoint operations

zturner added a comment. Strange, it was fine in the review, but wrong in the commit. Yea, that needs to be fixed. Repository: rL LLVM http://reviews.llvm.org/D13202 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D13202: [LLDB] Fix display of value of a vector variables in watchpoint operations

Strange, it was fine in the review, but wrong in the commit. Yea, that needs to be fixed. On Fri, Oct 9, 2015 at 11:09 AM Keno Fischer wrote: > loladiro added a subscriber: loladiro. > loladiro added a comment. > > Shouldn't that test have been inside the test/

Re: [Lldb-commits] [PATCH] D13202: [LLDB] Fix display of value of a vector variables in watchpoint operations

This revision was automatically updated to reflect the committed changes. Closed by commit rL249838: [LLDB] Fix display of value of a vector variables in watchpoint operations (authored by mohit.bhakkad). Changed prior to commit: http://reviews.llvm.org/D13202?vs=36837=36952#toc Repository:

Re: [Lldb-commits] [PATCH] D13202: [LLDB] Fix display of value of a vector variables in watchpoint operations

clayborg accepted this revision. clayborg added a comment. Looks good. Repository: rL LLVM http://reviews.llvm.org/D13202 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13202: [LLDB] Fix display of value of a vector variables in watchpoint operations

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Back from vacation, sorry for the delay. One quick fix as noted in inlined comments. Comment at: source/Breakpoint/Watchpoint.cpp:224-235 @@ -223,7 +223,14 @@

Re: [Lldb-commits] [PATCH] D13202: [LLDB] Fix display of value of a vector variables in watchpoint operations

zturner added a comment. Actually I'm wrong. Leave it enabled and I'll see what happens. clang-cl (which we require for windows tests) supports that syntax after all. Repository: rL LLVM http://reviews.llvm.org/D13202 ___ lldb-commits mailing

Re: [Lldb-commits] [PATCH] D13202: [LLDB] Fix display of value of a vector variables in watchpoint operations

mohit.bhakkad updated this revision to Diff 35879. mohit.bhakkad added a comment. Adding a simple test to check displayed value of vector Repository: rL LLVM http://reviews.llvm.org/D13202 Files: source/Breakpoint/Watchpoint.cpp

[Lldb-commits] [PATCH] D13202: [LLDB] Fix display of value of a vector variables in watchpoint operations

mohit.bhakkad created this revision. mohit.bhakkad added reviewers: clayborg, granata.enrico. mohit.bhakkad added subscribers: jaydeep, bhushan, sagar, nitesh.jain, lldb-commits. mohit.bhakkad set the repository for this revision to rL LLVM. Consider a vector variable 'v8i16 s0' Right now if we

Re: [Lldb-commits] [PATCH] D13202: [LLDB] Fix display of value of a vector variables in watchpoint operations

zturner added a subscriber: zturner. zturner requested changes to this revision. zturner added a reviewer: zturner. zturner added a comment. This revision now requires changes to proceed. Can you find a way to add a test for this? Repository: rL LLVM http://reviews.llvm.org/D13202