sivachandra updated this revision to Diff 36805.
sivachandra added a comment.
Rebase.
http://reviews.llvm.org/D13224
Files:
source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
test/lang/cpp/limit-debug-info/Makefile
test/lang/cpp/limit-debug-info/TestWithLimitDebugInfo.py
test/lang/
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Thanks for the info, now the patch makes more sense. That is some really lame
DWARF I must say, but alas we must deal with it. Looks good.
http://reviews.llvm.org/D13224
__
sivachandra added a comment.
I will use an example to explain the problem that this patch is trying to solve.
class.h:
class C
{
public:
C () {
c = 0;
}
virtual int method();
private:
int c;
};
class.cpp:
#include "class.h"
int
C::meth
clayborg added a comment.
So this fix is really to take care of the case where a class methods might be
defined on only some class instances? Can you explain more of what this fixes?
http://reviews.llvm.org/D13224
___
lldb-commits mailing list
lldb
sivachandra added a comment.
About Makefile changes in other tests, I will one day clean all places where
no-limit-debug-info shows up in the Makefile.
Just in case, zturner's comment about Makefiles on the other change came in a
day after I landed the change. So, I will have to do it in another
zturner added a comment.
Makefile stuff looks good. Is the plan to do the same thing for the previous
patch you submitted last week? What's the status of that?
http://reviews.llvm.org/D13224
___
lldb-commits mailing list
lldb-commits@lists.llvm.o
sivachandra updated this revision to Diff 35907.
sivachandra added a comment.
Rename test directory to limit-debug-info.
http://reviews.llvm.org/D13224
Files:
source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
test/lang/cpp/limit-debug-info/Makefile
test/lang/cpp/limit-debug-info/Tes
zturner added a subscriber: zturner.
zturner added a comment.
Can you change the name of the folder to something more descripive than
`pr24916`. For example, you could put `pr24916` in a comment in the test, but
the test itself could have a descriptive name. Enrico at Apple just went and
did
sivachandra created this revision.
sivachandra added a reviewer: clayborg.
sivachandra added a subscriber: lldb-commits.
This change fixes pr24916. As associated test has been added.
http://reviews.llvm.org/D13224
Files:
source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
test/lang/cpp/p
