mstorsjo added a comment.
This seems to break the build with GCC (tested with the system compiler GCC 9
on Ubuntu 20.04):
ld.lld: error: undefined symbol: lldb_private::CommandInterpreter::g_argument
>>> referenced by CommandAlias.cpp
>>>
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
jingham marked an inline comment as done.
Closed by commit rG6c089b2af5d8: Be more careful to maintain quoting
information when parsing
jingham marked an inline comment as done.
jingham added inline comments.
Comment at: lldb/source/Interpreter/Options.cpp:1026
+} else
+ option_to_insert = CommandInterpreter::g_no_argument;
+
hawkinsw wrote:
> Question: Could we drop the final `else` if
hawkinsw added a comment.
Sorry if these comments are not helpful! Everything looks great!
Comment at: lldb/source/Interpreter/Options.cpp:1026
+} else
+ option_to_insert = CommandInterpreter::g_no_argument;
+
Question: Could we drop the final `else`
jingham added a comment.
The other bit of this patch was a cleanup I made as I was understanding the
alias parsing where we were using specific tokens in the parsed alias, but the
tokens were ad hoc strings, so I replaced them with constants.
Repository:
rG LLVM Github Monorepo
CHANGES
jingham created this revision.
jingham added reviewers: JDevlieghere, clayborg.
Herald added a subscriber: jeroen.dobbelaere.
Herald added a project: All.
jingham requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
At present, backtick
