[Lldb-commits] [PATCH] D133129: [lldb] Add boilerplate for debugger interrupts

JDevlieghere abandoned this revision. JDevlieghere added a comment. Jim is working on another way to tackle this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133129/new/ https://reviews.llvm.org/D133129 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D133129: [lldb] Add boilerplate for debugger interrupts

jingham added a comment. In D133129#3780028 , @labath wrote: > In D133129#3778125 , @jingham wrote: > >> To be clear, I'm not trying to implement a preemptive interrupt using these >> callbacks. There are so

[Lldb-commits] [PATCH] D133129: [lldb] Add boilerplate for debugger interrupts

labath added a comment. In D133129#3778125 , @jingham wrote: > To be clear, I'm not trying to implement a preemptive interrupt using these > callbacks. There are so many places where lldb is doing work that you really > can't interrupt - e.g. we can't

[Lldb-commits] [PATCH] D133129: [lldb] Add boilerplate for debugger interrupts

jingham added a comment. To be clear, I'm not trying to implement a preemptive interrupt using these callbacks. There are so many places where lldb is doing work that you really can't interrupt - e.g. we can't drop symbol parsing and then pick it up again later - that that doesn't really even

[Lldb-commits] [PATCH] D133129: [lldb] Add boilerplate for debugger interrupts

labath added a comment. I've added you to D133410 , as I think it demonstrates very well the difficulties in getting two threads to talk to one another. This code has been here since forever (and may have contributed to your desire to introduce interrupts),

[Lldb-commits] [PATCH] D133129: [lldb] Add boilerplate for debugger interrupts

labath added a comment. I don't know how this is intended to be used, but I find it a rather heavyweight approach towards implementing, well... anything. The idea that something as innocuous as SBAddress::IsValid() will end up iterating through _all_ SBDebugger objects seems wrong, regardless

[Lldb-commits] [PATCH] D133129: [lldb] Add boilerplate for debugger interrupts

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133129/new/ https://reviews.llvm.org/D133129 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D133129: [lldb] Add boilerplate for debugger interrupts

JDevlieghere created this revision. JDevlieghere added a reviewer: jingham. Herald added a subscriber: mgorny. Herald added a project: All. JDevlieghere requested review of this revision. Jim is looking into adding support for interrupts to the SB API. Part of that work requires clearing the