[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

thakis added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/CMakeLists.txt:47 lldbUtility +lldbPluginDynamicLoaderDarwinKernel +lldbPluginObjectContainerMachOFileset jasonmolenda wrote: > jasonmolenda wrote: > > thakis wrote: > > >

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

jasonmolenda added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/CMakeLists.txt:47 lldbUtility +lldbPluginDynamicLoaderDarwinKernel +lldbPluginObjectContainerMachOFileset jasonmolenda wrote: > thakis wrote: > > This causes a

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

jasonmolenda added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/CMakeLists.txt:47 lldbUtility +lldbPluginDynamicLoaderDarwinKernel +lldbPluginObjectContainerMachOFileset thakis wrote: > This causes a dependency cycle: > >

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

thakis added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/CMakeLists.txt:47 lldbUtility +lldbPluginDynamicLoaderDarwinKernel +lldbPluginObjectContainerMachOFileset This causes a dependency cycle:

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

This revision was automatically updated to reflect the committed changes. jasonmolenda marked an inline comment as done. Closed by commit rG1a608cfb5ca8: Recognize a platform binary in ProcessGDBRemote which determines plugins (authored by jasonmolenda). Changed prior to commit:

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

jasonmolenda marked 2 inline comments as done. jasonmolenda added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp:924 + addr_t input_addr) { + Status error; + WritableDataBufferSP

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. A small comment but otherwise this LGTM. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp:924 +

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

jasonmolenda updated this revision to Diff 459191. jasonmolenda marked 5 inline comments as done. jasonmolenda added a comment. Update patch to incorporate Jonas & Pavel's feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133534/new/

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

jasonmolenda marked 8 inline comments as done. jasonmolenda added inline comments. Comment at: lldb/include/lldb/Target/Platform.h:870-874 + virtual bool LoadSpecialBinaryAndSetDynamicLoader(Process *process, +lldb::addr_t

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

jasonmolenda updated this revision to Diff 459094. jasonmolenda added a comment. Update patch to include more surrounding context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133534/new/ https://reviews.llvm.org/D133534 Files:

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

JDevlieghere added a comment. The current patch didn't have context so I just left a bunch of nits. Comment at: lldb/include/lldb/Target/Platform.h:870-874 + virtual bool LoadSpecialBinaryAndSetDynamicLoader(Process *process, +

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

labath added inline comments. Comment at: lldb/unittests/Interpreter/CMakeLists.txt:17-18 lldbInterpreter + lldbPluginDynamicLoaderDarwinKernel + lldbPluginObjectContainerMachOFileset lldbPluginPlatformMacOSX These dependencies should be

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

jasonmolenda updated this revision to Diff 458970. jasonmolenda added a comment. Update the patch to address Jim's comments/suggestions. Biggest change was to clean up how DynamicLoaderDarwinKernel filters out any kernels in the Target that don't match the UUID of the actually running kernel.

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

jasonmolenda marked an inline comment as done. jasonmolenda added a comment. Thanks Jim! Really helpful feedback and questions. Comment at: lldb/source/Core/DynamicLoader.cpp:191 ModuleSP module_sp; PlatformSP platform_sp = process->GetTarget().GetPlatform(); Target

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

jingham added a comment. So far just a bunch of random comments... Comment at: lldb/include/lldb/Target/Platform.h:1055 + /// Given an address of a binary, the platform may be able to + /// set the correct DynamicLoader plugin that should be used for Are

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

jasonmolenda created this revision. jasonmolenda added reviewers: JDevlieghere, jingham. jasonmolenda added a project: LLDB. Herald added a subscriber: mgorny. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. In an internal