[Lldb-commits] [PATCH] D133876: [lldb][tests][NFC] Move C++ gmodules tests into new gmodules/ subdirectory

dyung added a comment. In D133876#3797145 , @Michael137 wrote: > In D133876#3797098 , @dyung wrote: > >> In D133876#3796923 , @Michael137 >> wrote: >> >>> In

[Lldb-commits] [PATCH] D133876: [lldb][tests][NFC] Move C++ gmodules tests into new gmodules/ subdirectory

Michael137 added a comment. In D133876#3797098 , @dyung wrote: > In D133876#3796923 , @Michael137 > wrote: > >> In D133876#3796847 , @dyung wrote: >> >>> @Michael137,

[Lldb-commits] [PATCH] D133876: [lldb][tests][NFC] Move C++ gmodules tests into new gmodules/ subdirectory

dyung added a comment. In D133876#3796923 , @Michael137 wrote: > In D133876#3796847 , @dyung wrote: > >> @Michael137, your change is causing cmake to fail on one of our bots: >> >>

Re: [Lldb-commits] [PATCH] D133876: [lldb][tests][NFC] Move C++ gmodules tests into new gmodules/ subdirectory

To be more specific, the problem is that there used to be a directory in the test suite called gmodules-template and Michael moved it to gmodules/template to better organize the tests. But our rule for making a test name from subdirectories is to replace the "/" with a "-" so these two ended

[Lldb-commits] [PATCH] D133876: [lldb][tests][NFC] Move C++ gmodules tests into new gmodules/ subdirectory

Michael137 added a comment. In D133876#3796847 , @dyung wrote: > @Michael137, your change is causing cmake to fail on one of our bots: > > https://lab.llvm.org/buildbot/#/builders/217/builds/11819 > > CMake Error at cmake/modules/AddLLVM.cmake:1867

[Lldb-commits] [PATCH] D133876: [lldb][tests][NFC] Move C++ gmodules tests into new gmodules/ subdirectory

dyung added a comment. @Michael137, your change is causing cmake to fail on one of our bots: https://lab.llvm.org/buildbot/#/builders/217/builds/11819 CMake Error at cmake/modules/AddLLVM.cmake:1867 (add_custom_target): add_custom_target cannot create target

[Lldb-commits] [PATCH] D133876: [lldb][tests][NFC] Move C++ gmodules tests into new gmodules/ subdirectory

This revision was automatically updated to reflect the committed changes. Closed by commit rG3b44c9af8efd: [lldb][tests] Move C++ gmodules tests into new gmodules/ subdirectory (authored by Michael137). Changed prior to commit: https://reviews.llvm.org/D133876?vs=460143=460169#toc Repository: