[Lldb-commits] [PATCH] D133973: [test] Fix LLDB tests with just-built libcxx when using a target directory.

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb0eb9d8dd5a: [test] Fix LLDB tests with just-built libcxx when using a target directory. (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D133973: [test] Fix LLDB tests with just-built libcxx when using a target directory.

rupprecht added inline comments. Comment at: lldb/test/API/lit.cfg.py:178-179 + dotest_cmd += ['--libcxx-include-dir', config.libcxx_include_dir] + if is_configured('libcxx_include_target_dir'): +dotest_cmd += ['--libcxx-include-target-dir',

[Lldb-commits] [PATCH] D133973: [test] Fix LLDB tests with just-built libcxx when using a target directory.

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Comment at: lldb/test/API/lit.cfg.py:178-179 + dotest_cmd += ['--libcxx-include-dir', config.libcxx_include_dir] + if is_configured('libcxx_include_target_dir'): +dotest_cmd +=

[Lldb-commits] [PATCH] D133973: [test] Fix LLDB tests with just-built libcxx when using a target directory.

fdeazeve accepted this revision. fdeazeve added a comment. This revision is now accepted and ready to land. This LGTM and it worked without issues when I ran some tests on my machine, but please let @JDevlieghere have another look Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D133973: [test] Fix LLDB tests with just-built libcxx when using a target directory.

fdeazeve added inline comments. Comment at: lldb/test/API/lit.cfg.py:176 if platform.system() != 'Windows': -if is_configured('llvm_include_dir') and is_configured('llvm_libs_dir'): - dotest_cmd += ['--libcxx-include-dir', os.path.join(config.llvm_include_dir,

[Lldb-commits] [PATCH] D133973: [test] Fix LLDB tests with just-built libcxx when using a target directory.

rupprecht added inline comments. Comment at: lldb/test/API/lit.cfg.py:176 if platform.system() != 'Windows': -if is_configured('llvm_include_dir') and is_configured('llvm_libs_dir'): - dotest_cmd += ['--libcxx-include-dir', os.path.join(config.llvm_include_dir,

[Lldb-commits] [PATCH] D133973: [test] Fix LLDB tests with just-built libcxx when using a target directory.

fdeazeve added inline comments. Comment at: lldb/test/API/lit.cfg.py:176 if platform.system() != 'Windows': -if is_configured('llvm_include_dir') and is_configured('llvm_libs_dir'): - dotest_cmd += ['--libcxx-include-dir', os.path.join(config.llvm_include_dir,

[Lldb-commits] [PATCH] D133973: [test] Fix LLDB tests with just-built libcxx when using a target directory.

fdeazeve added a comment. In D133973#3793398 , @JDevlieghere wrote: > does this result in another search path or does that replace the former I did some local testing and it seems to add another path. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D133973: [test] Fix LLDB tests with just-built libcxx when using a target directory.

rupprecht added a comment. In D133973#3793398 , @JDevlieghere wrote: > Do we need both `LIBCPP_INCLUDE_DIR` and `LIBCPP_INCLUDE_TARGET_DIR`? I see > we pass another `-cxx-isystem` flag, does this result in another search path > or does that replace

[Lldb-commits] [PATCH] D133973: [test] Fix LLDB tests with just-built libcxx when using a target directory.

JDevlieghere added a comment. Do we need both `LIBCPP_INCLUDE_DIR` and `LIBCPP_INCLUDE_TARGET_DIR`? I see we pass another `-cxx-isystem` flag, does this result in another search path or does that replace the former? If we only need one, we could set `LIBCPP_INCLUDE_DIR` to

[Lldb-commits] [PATCH] D133973: [test] Fix LLDB tests with just-built libcxx when using a target directory.

rupprecht created this revision. rupprecht added reviewers: JDevlieghere, fdeazeve. Herald added a subscriber: mgorny. Herald added a project: All. rupprecht requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In certain configurations, libc++