alvinhochun abandoned this revision.
alvinhochun added a comment.
Handled in separate changes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134133/new/
https://reviews.llvm.org/D134133
___
lldb-commits
alvinhochun added a comment.
Separated the first part with some new changes here:
https://reviews.llvm.org/D134196
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134133/new/
https://reviews.llvm.org/D134133
alvinhochun added inline comments.
Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:819
+ if (exported->GetType() != lldb::eSymbolTypeReExported &&
+ exported->GetAddressRef() == symbols[i].GetAddressRef()) {
+
mstorsjo added inline comments.
Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:787
+ Symbol *symbols = symtab.Extend(num_syms);
+ uint32_t i = 0;
+ for (const auto _ref : m_binary->symbols()) {
alvinhochun wrote:
> mstorsjo wrote:
> >
alvinhochun added a comment.
Thanks for the review. Yes I shall split the changes into smaller pieces to aid
review.
Comment at: lldb/source/Commands/CommandObjectTarget.cpp:1558
}
+ strm.IndentLess();
}
mstorsjo wrote:
> Looks
mstorsjo added a comment.
So previously, LLDB essentially used the COFF symbol table for executables, but
only the list of exported symbols for DLLs, ignoring (or, reading and then
overwriting) the symbol table for any DLL with exports? Then this certainly
does look like a good direction.
alvinhochun created this revision.
alvinhochun added reviewers: labath, DavidSpickett, mstorsjo.
Herald added a project: All.
alvinhochun requested review of this revision.
Herald added projects: LLDB, LLVM.
Herald added subscribers: llvm-commits, lldb-commits.
This reimplements
