[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

This revision was automatically updated to reflect the committed changes. Closed by commit rGa842f7405679: [lldb] Support simplified template names (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134378/new/

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

aeubanks updated this revision to Diff 471585. aeubanks added a comment. rename variables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134378/new/ https://reviews.llvm.org/D134378 Files: lldb/include/lldb/Symbol/CompilerType.h

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D134378#3890302 , @aeubanks wrote: > regarding the failure in TestCPPBreakpointLocations.py (added recently in > https://reviews.llvm.org/D135921,

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

aeubanks added inline comments. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:3809 +ConstString TypeSystemClang::GetBaseName(lldb::opaque_compiler_type_t type) { + if (!type) this was mostly copied from `GetTypeName` above, not sure if

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

aeubanks updated this revision to Diff 471375. aeubanks marked an inline comment as done. aeubanks added a comment. combine GetBaseName into GetTypeName Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134378/new/ https://reviews.llvm.org/D134378

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

Michael137 added inline comments. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:3831 + + clang::PrintingPolicy printing_policy(GetTypePrintingPolicy()); + printing_policy.SuppressScope = true; Could we just re-use `GetTypeName` and add

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

aeubanks added a comment. regarding the failure in TestCPPBreakpointLocations.py (added recently in https://reviews.llvm.org/D135921, seems like it's catching real issues with this patch), it looks like the manual dwarf index needs a similar fix to this In D134378#3888462

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

aeubanks updated this revision to Diff 471330. aeubanks added a comment. fix nested types by introducing Type::GetBaseName() add expr eval tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134378/new/ https://reviews.llvm.org/D134378 Files:

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

labath added a comment. I can't say I fully understand all of this code, but I also don't know who would, so I guess I'll just say it "looks good" :) I am wondering about the testing situation though. If I understand correctly, you've run the test suite with hardcoded simplified names, and it

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

aeubanks updated this revision to Diff 470617. aeubanks added a comment. revert breakpoint test change we can leave that to a later change, so I think this change is ready to go Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134378/new/

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

aeubanks added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1551 +} +if (!all_template_names.empty()) { + all_template_names.append(">"); labath wrote: > When can this be empty? Should we still include

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

aeubanks updated this revision to Diff 470321. aeubanks marked 3 inline comments as done. aeubanks added a comment. address comments rebasing to ToT, TestCPPBreakpointsLocations.py is failing when using -gsimple-template-names. still working on that Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1528 +DWARFASTParserClang::GetTemplateParametersString(const DWARFDIE ) { + if (llvm::StringRef(die.GetName()).contains("<")) +return std::string();

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

Michael137 added subscribers: jingham, labath, aprantl. Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2500 +const llvm::StringRef nameRef = name.GetStringRef(); +auto it = nameRef.find('<'); +if (it !=

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

rnk added a comment. @Michael137, are you comfortable approving this, or can you reroute to a reviewer who can help us with this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134378/new/ https://reviews.llvm.org/D134378

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

aeubanks updated this revision to Diff 467946. aeubanks added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134378/new/ https://reviews.llvm.org/D134378 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

aeubanks added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1561 +std::string +DWARFASTParserClang::GetCPlusPlusQualifiedName(const DWARFDIE ) { + if (!die.IsValid()) dblaikie wrote: > Sorry, when I gave feedback on

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

dblaikie added a comment. Looking pretty good to me FWIW Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1561 +std::string +DWARFASTParserClang::GetCPlusPlusQualifiedName(const DWARFDIE ) { + if (!die.IsValid()) Sorry, when I gave

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

aeubanks added inline comments. Comment at: lldb/test/API/lang/cpp/unique-types2/TestUniqueTypes.py:1 +""" +Test that we return only the requested template instantiation. Michael137 wrote: > I think it would be good to test this with >

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

aeubanks updated this revision to Diff 465926. aeubanks added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134378/new/ https://reviews.llvm.org/D134378 Files:

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

Michael137 added inline comments. Comment at: lldb/test/API/lang/cpp/unique-types2/TestUniqueTypes.py:1 +""" +Test that we return only the requested template instantiation. I think it would be good to test this with

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1528 +DWARFASTParserClang::GetTemplateParametersString(const DWARFDIE ) { + if (llvm::StringRef(die.GetName()).contains("<")) +return std::string();

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1528 +DWARFASTParserClang::GetTemplateParametersString(const DWARFDIE ) { + if (llvm::StringRef(die.GetName()).contains("<")) +return std::string();

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1528 +DWARFASTParserClang::GetTemplateParametersString(const DWARFDIE ) { + if (llvm::StringRef(die.GetName()).contains("<")) +return std::string();

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

aeubanks added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1558-1560 +if (template_param_infos.hasParameterPack()) { + args = template_param_infos.packed_args->args; +} dblaikie

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

aeubanks updated this revision to Diff 465586. aeubanks marked 5 inline comments as done. aeubanks added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134378/new/ https://reviews.llvm.org/D134378 Files:

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2480 + // templates parameters, try again with the template parameters stripped since + // with simplified template names the DT_name may only contain the base name. + if

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1550 + if (die.IsValid()) { +auto get_template_params_string = [this](DWARFDIE die) { + if (llvm::StringRef(die.GetName()).contains("<"))

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

dblaikie added inline comments. Herald added a subscriber: JDevlieghere. Comment at: lldb/packages/Python/lldbsuite/test/make/Makefile.rules:230-231 -DEBUG_INFO_FLAG ?= -g +# DO NOT SUBMIT +DEBUG_INFO_FLAG ?= -g -gsimple-template-names Oh, nifty place to

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

aeubanks created this revision. Herald added a reviewer: shafik. Herald added a project: All. aeubanks updated this revision to Diff 461963. aeubanks added a comment. aeubanks added a reviewer: dblaikie. aeubanks published this revision for review. Herald added a project: LLDB. Herald added a