This revision was automatically updated to reflect the committed changes.
Closed by commit rG69c661a65ff8: [lldb] Skip check for conflicting filter/synth
when adding a new regex. (authored by jgorbe).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Let's just skip this check. Though it might be fun to implement an
emptyness-of-intersection check for two regular expressions, that's: a)
overkill; b) impossible if you include
jgorbe added a comment.
Ping? If anyone has other suggestions for reviewers I'd appreciate them.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134570/new/
https://reviews.llvm.org/D134570
___
lldb-commits mailing list
labath added subscribers: jingham, labath.
labath added a reviewer: jingham.
labath added a comment.
The current behavior is clearly not useful, but I don't have any context to be
able to determine whether there's something else that can be done about that.
@jingham might have it.
CHANGES
jgorbe updated this revision to Diff 462637.
jgorbe added a comment.
Added a couple of test cases to TestDataFormatterPythonSynth.py.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134570/new/
https://reviews.llvm.org/D134570
Files:
lldb/source/Commands/CommandObjectType.cpp
jgorbe created this revision.
jgorbe added a project: LLDB.
Herald added a subscriber: JDevlieghere.
Herald added a project: All.
jgorbe requested review of this revision.
When adding a new synthetic child provider, we check for an existing
conflicting filter in the same category (and vice
