[Lldb-commits] [PATCH] D134585: [lldb][COFF] Map symbols without base+complex type as 'Data' type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8a67a05e9334: [lldb][COFF] Map symbols without base+complex type as Data type (authored by alvinhochun, committed by mstorsjo). Repository: rG

[Lldb-commits] [PATCH] D134585: [lldb][COFF] Map symbols without base+complex type as 'Data' type

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. Would help if I actually clicked the buttons yes :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134585/new/

[Lldb-commits] [PATCH] D134585: [lldb][COFF] Map symbols without base+complex type as 'Data' type

mstorsjo added a comment. In D134585#3814463 , @DavidSpickett wrote: >> MSVC/link.exe doesn't write symbols into linked PE images at all. > > So by the time we get to a debugger, it's not an issue anyway. Yep, most of these patches about symbol table

[Lldb-commits] [PATCH] D134585: [lldb][COFF] Map symbols without base+complex type as 'Data' type

DavidSpickett added a comment. > MSVC/link.exe doesn't write symbols into linked PE images at all. So by the time we get to a debugger, it's not an issue anyway. Then this LGTM. Thanks for all these improvements btw, I expect Linaro's Windows on Arm efforts appreciate them too. Repository:

[Lldb-commits] [PATCH] D134585: [lldb][COFF] Map symbols without base+complex type as 'Data' type

mstorsjo added a comment. In D134585#3814458 , @DavidSpickett wrote: > You're the expert on what the linker does and the code looks fine. > > Is it possible that msvc uses these `IMAGE_SYM_TYPE_NULL` in a different way > that could cause a problem?

[Lldb-commits] [PATCH] D134585: [lldb][COFF] Map symbols without base+complex type as 'Data' type

DavidSpickett added a comment. You're the expert on what the linker does and the code looks fine. Is it possible that msvc uses these `IMAGE_SYM_TYPE_NULL` in a different way that could cause a problem? Worst that happens is we get a bunch of symbols available in expressions that shouldn't be?

[Lldb-commits] [PATCH] D134585: [lldb][COFF] Map symbols without base+complex type as 'Data' type

mstorsjo added a comment. This LGTM, but I'll leave it to some LLDB maintainer to formally approve. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134585/new/ https://reviews.llvm.org/D134585 ___

[Lldb-commits] [PATCH] D134585: [lldb][COFF] Map symbols without base+complex type as 'Data' type

alvinhochun created this revision. alvinhochun added reviewers: labath, DavidSpickett, mstorsjo. Herald added a project: All. alvinhochun requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Both LLD and GNU ld write global/static variables to