[Lldb-commits] [PATCH] D134636: [lldb][Windows] Always call SetExecutableModule on debugger connected

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfe17e026959c: [lldb][Windows] Always call SetExecutableModule on debugger connected (authored by alvinhochun, committed by mstorsjo). Repository:

[Lldb-commits] [PATCH] D134636: [lldb][Windows] Always call SetExecutableModule on debugger connected

alvinhochun added inline comments. Comment at: lldb/test/Shell/Target/dependent-modules-nodupe-windows.test:6-9 +# RUN: %clang_host -g0 -O0 -shared %S/Inputs/shlib.c -o %t.shlib.dll \ +# RUN: %if windows-msvc %{-Wl,-implib:%t.shlib.lib%} \ +# RUN: %else

[Lldb-commits] [PATCH] D134636: [lldb][Windows] Always call SetExecutableModule on debugger connected

alvinhochun updated this revision to Diff 463459. alvinhochun edited the summary of this revision. alvinhochun added a comment. Actually update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134636/new/

[Lldb-commits] [PATCH] D134636: [lldb][Windows] Always call SetExecutableModule on debugger connected

alvinhochun updated this revision to Diff 463458. alvinhochun added a comment. Updated the patch to be standalone. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134636/new/ https://reviews.llvm.org/D134636 Files:

[Lldb-commits] [PATCH] D134636: [lldb][Windows] Always call SetExecutableModule on debugger connected

jasonmolenda added a comment. This looks good to me, fwiw. I agree with Pavel about hardcoding the order that libraries might appear unless that ordering is essentially considered API. We could get in a situation where different versions of windows report the binaries in different order, and

[Lldb-commits] [PATCH] D134636: [lldb][Windows] Always call SetExecutableModule on debugger connected

alvinhochun added a comment. Okay, I'll rebase the change to remove the dependency on D134581 . Comment at: lldb/test/Shell/Target/dependent-modules-nodupe-windows.test:21-22 # CHECK-NEXT: .main.exe -# CHECK-NEXT: .shlib.dll +# CHECK-NEXT:

[Lldb-commits] [PATCH] D134636: [lldb][Windows] Always call SetExecutableModule on debugger connected

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/test/Shell/Target/dependent-modules-nodupe-windows.test:21-22 # CHECK-NEXT: .main.exe -# CHECK-NEXT: .shlib.dll +# CHECK-NEXT: ntdll.dll +# CHECK-NEXT:

[Lldb-commits] [PATCH] D134636: [lldb][Windows] Always call SetExecutableModule on debugger connected

mstorsjo added a reviewer: jasonmolenda. mstorsjo added a subscriber: jasonmolenda. mstorsjo added a comment. The test runs fine on Windows, but I'm not familiar with these aspects of lldb to (yet) have a good opinion on it; adding @jasonmolenda to the review who commented on the previous one

[Lldb-commits] [PATCH] D134636: [lldb][Windows] Always call SetExecutableModule on debugger connected

alvinhochun created this revision. Herald added a project: All. alvinhochun requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In `ProcessWindows::OnDebuggerConnected` (triggered from `CREATE_PROCESS_DEBUG_EVENT`), we should always call