[Lldb-commits] [PATCH] D134882: [lldb] Move breakpoint hit reset code to Target::CleanupProcess

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG08c4a6795ac4: [lldb] Move breakpoint hit reset code to Target::CleanupProcess (authored by labath). Repository: rG

[Lldb-commits] [PATCH] D134882: [lldb] Move breakpoint hit reset code to Target::CleanupProcess

labath added a comment. In D134882#3831137 , @jingham wrote: > That seems fine. I think it's useful to be able to see breakpoint hit counts > up to the point where you start a new process. From looking at the code, it > looks like putting the clear

[Lldb-commits] [PATCH] D134882: [lldb] Move breakpoint hit reset code to Target::CleanupProcess

labath updated this revision to Diff 465012. labath added a comment. Check breakpoint hit counts after termination Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134882/new/ https://reviews.llvm.org/D134882 Files: lldb/source/Target/Process.cpp

[Lldb-commits] [PATCH] D134882: [lldb] Move breakpoint hit reset code to Target::CleanupProcess

jingham added a comment. That seems fine. I think it's useful to be able to see breakpoint hit counts up to the point where you start a new process. From looking at the code, it looks like putting the clear in CleanupProcess will do that. If you agree this is useful, can you add to the test

[Lldb-commits] [PATCH] D134882: [lldb] Move breakpoint hit reset code to Target::CleanupProcess

labath added a comment. Here's an even better idea. I've now doing it in Target::CleanupProcess, right next to the code for resetting **watch**point hit counts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134882/new/