Re: [Lldb-commits] [PATCH] D13548: [LLDB][MIPS] fix watchpoint searched on client side for same masked variables

2015-10-09 Thread Mohit Bhakkad via lldb-commits
mohit.bhakkad added a comment. In http://reviews.llvm.org/D13548#262873, @clayborg wrote: > Add space in between if and opening ( and this is good to go. Thanks, addressed it while commiting. Repository: rL LLVM http://reviews.llvm.org/D13548

Re: [Lldb-commits] [PATCH] D13548: [LLDB][MIPS] fix watchpoint searched on client side for same masked variables

2015-10-09 Thread Mohit Bhakkad via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL249837: [LLDB][MIPS] fix watchpoint searched on client side for same masked variables (authored by mohit.bhakkad). Changed prior to commit: http://reviews.llvm.org/D13548?vs=36838&id=36951#toc Reposito

Re: [Lldb-commits] [PATCH] D13548: [LLDB][MIPS] fix watchpoint searched on client side for same masked variables

2015-10-08 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. Add space in between if and opening ( and this is good to go. Repository: rL LLVM http://reviews.llvm.org/D13548 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llv

Re: [Lldb-commits] [PATCH] D13548: [LLDB][MIPS] fix watchpoint searched on client side for same masked variables

2015-10-08 Thread Bruce Mitchener via lldb-commits
brucem added a subscriber: brucem. brucem requested changes to this revision. brucem added a reviewer: brucem. This revision now requires changes to proceed. Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:2108 @@ -2107,1 +2107,3 @@

[Lldb-commits] [PATCH] D13548: [LLDB][MIPS] fix watchpoint searched on client side for same masked variables

2015-10-08 Thread Mohit Bhakkad via lldb-commits
mohit.bhakkad created this revision. mohit.bhakkad added reviewers: clayborg, jingham. mohit.bhakkad added subscribers: jaydeep, bhushan, sagar, nitesh.jain, lldb-commits. mohit.bhakkad set the repository for this revision to rL LLVM. On MIPS architecture, it is possible to use same hardware regi