This revision was automatically updated to reflect the committed changes.
Closed by commit rGf6eb089734dd: [trace][intelpt] Fix multi CPU decoding TSC
assertion error (authored by jj10306).
Changed prior to commit:
https://reviews.llvm.org/D136610?vs=470472=470887#toc
Repository:
rG LLVM
wallace accepted this revision.
wallace added a comment.
This revision is now accepted and ready to land.
thanks. Your explanation of why the verbose error is useful was good :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136610/new/
jj10306 added inline comments.
Comment at: lldb/source/Plugins/Trace/intel-pt/LibiptDecoder.cpp:299-307
+ uint64_t offset;
+ int status = pt_insn_get_offset(m_decoder_up.get(), );
+ if (!IsLibiptError(status)) {
+err_msg =
+
jj10306 updated this revision to Diff 470472.
jj10306 marked 7 inline comments as done.
jj10306 added a comment.
Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136610/new/
https://reviews.llvm.org/D136610
Files:
wallace requested changes to this revision.
wallace added a comment.
This revision now requires changes to proceed.
pretty good! I just left cosmetic requests
Comment at: lldb/source/Plugins/Trace/intel-pt/LibiptDecoder.cpp:285-312
+ if (event.has_tsc) {
+if
jj10306 created this revision.
jj10306 added reviewers: wallace, persona0220.
Herald added a project: All.
jj10306 requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Occasionally the assertion that enforces increasing TSC values in
