ovyalov closed this revision.
ovyalov added a comment.
Submitted as r250474
http://reviews.llvm.org/D13754
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added inline comments.
Comment at: source/Host/posix/DomainSocket.cpp:74
@@ +73,3 @@
+FileSystem::Unlink(FileSpec{name, true});
+
+Error error;
If we're going to use unique names, then this won't be necessary (and I would
much rather see a random
ovyalov added inline comments.
Comment at: source/Host/posix/DomainSocket.cpp:74
@@ +73,3 @@
+FileSystem::Unlink(FileSpec{name, true});
+
+Error error;
labath wrote:
> If we're going to use unique names, then this won't be necessary (and I would
> much
ovyalov updated this revision to Diff 37525.
ovyalov marked 3 inline comments as done.
ovyalov added a comment.
Addressed review suggestions.
Please take another look.
http://reviews.llvm.org/D13754
Files:
include/lldb/Host/Socket.h
include/lldb/Host/common/TCPSocket.h
ovyalov added inline comments.
Comment at: source/Host/common/Socket.cpp:356
@@ -740,3 +355,3 @@
-uint16_t Socket::GetLocalPortNumber(const NativeSocket& socket)
+size_t Socket::Send(const void *buf, const size_t num_bytes)
{
Good point - done.
ovyalov created this revision.
ovyalov added reviewers: clayborg, zturner, labath.
ovyalov added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
There are a few reasons for this change:
- Support generic logic flow for different socket types - a preparation
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Can we change "TcpSocket" to be "TCPSocket" and "UdpSocket" to be "UDPSocket"
in all code and in the file names? Other than that it looks good.
Comment at:
