wallace accepted this revision.
wallace added inline comments.
This revision is now accepted and ready to land.
Comment at: lldb/source/API/SBTraceCursor.cpp:127-131
+double SBTraceCursor::GetWallClockTime() const {
+ LLDB_INSTRUMENT_VA(this);
+
+ const auto _wall_clock_time =
jj10306 updated this revision to Diff 474092.
jj10306 added a comment.
update the way items with no timestamps are handled
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137645/new/
https://reviews.llvm.org/D137645
Files:
hawkinsw added inline comments.
Comment at: lldb/source/API/SBTraceCursor.cpp:127-131
+double SBTraceCursor::GetWallClockTime() const {
+ LLDB_INSTRUMENT_VA(this);
+
+ const auto _wall_clock_time = m_opaque_sp->GetWallClockTime();
+ return maybe_wall_clock_time ?
wallace requested changes to this revision.
wallace added inline comments.
This revision now requires changes to proceed.
Comment at: lldb/include/lldb/API/SBTraceCursor.h:175
+ /// if not available.
+ double GetWallClockTime() const;
+ /// \}
mention
hawkinsw added inline comments.
Comment at: lldb/source/API/SBTraceCursor.cpp:131
+ const auto _wall_clock_time = m_opaque_sp->GetWallClockTime();
+ return maybe_wall_clock_time ? *maybe_wall_clock_time : -1.0;
+}
jj10306 wrote:
> open to suggestions on the
jj10306 added inline comments.
Herald added a subscriber: JDevlieghere.
Comment at: lldb/source/API/SBTraceCursor.cpp:131
+ const auto _wall_clock_time = m_opaque_sp->GetWallClockTime();
+ return maybe_wall_clock_time ? *maybe_wall_clock_time : -1.0;
+}
open
jj10306 created this revision.
jj10306 added reviewers: wallace, persona0220.
Herald added a project: All.
jj10306 requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Test Plan:
Repository:
rG LLVM Github Monorepo
