[Lldb-commits] [PATCH] D137983: [lldb] Disable looking at pointee types to find synthetic value for non-ObjC

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b80e8ee1fca: [lldb] Disable looking at pointee types to find synthetic value for non-ObjC (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D137983: [lldb] Disable looking at pointee types to find synthetic value for non-ObjC

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Okay, here goes nothing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137983/new/ https://reviews.llvm.org/D137983

[Lldb-commits] [PATCH] D137983: [lldb] Disable looking at pointee types to find synthetic value for non-ObjC

aeubanks added a comment. would somebody be willing to lgtm the workaround while we investigate further since this is currently breaking a fairly typical debugging session? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137983/new/

[Lldb-commits] [PATCH] D137983: [lldb] Disable looking at pointee types to find synthetic value for non-ObjC

aeubanks added a comment. In D137983#3930973 , @labath wrote: > We have tests for shared libraries (grep for DYLIB_C(XX)_SOURCES)), but it's > easier to reproduce this problem by compiling one CU with -g0 -- see inline > comment. (If you are creating

[Lldb-commits] [PATCH] D137983: [lldb] Disable looking at pointee types to find synthetic value for non-ObjC

aeubanks updated this revision to Diff 476199. aeubanks added a comment. add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137983/new/ https://reviews.llvm.org/D137983 Files: lldb/source/Core/ValueObject.cpp

[Lldb-commits] [PATCH] D137983: [lldb] Disable looking at pointee types to find synthetic value for non-ObjC

labath added a comment. We have tests for shared libraries (grep for DYLIB_C(XX)_SOURCES)), but it's easier to reproduce this problem by compiling one CU with -g0 -- see inline comment. (If you are creating an "API" test for this, beware that their default is to build everything with

[Lldb-commits] [PATCH] D137983: [lldb] Disable looking at pointee types to find synthetic value for non-ObjC

aeubanks added inline comments. Comment at: lldb/source/Core/ValueObject.cpp:2676-2677 if (!m_deref_valobj) { - if (HasSyntheticValue()) { + // FIXME: C++ stdlib formatters break with incomplete types (e.g. + // `std::vector &`). Remove ObjC restriction once

[Lldb-commits] [PATCH] D137983: [lldb] Disable looking at pointee types to find synthetic value for non-ObjC

aeubanks updated this revision to Diff 475627. aeubanks added a comment. add bug Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137983/new/ https://reviews.llvm.org/D137983 Files: lldb/source/Core/ValueObject.cpp Index:

[Lldb-commits] [PATCH] D137983: [lldb] Disable looking at pointee types to find synthetic value for non-ObjC

dblaikie added inline comments. Comment at: lldb/source/Core/ValueObject.cpp:2676-2677 if (!m_deref_valobj) { - if (HasSyntheticValue()) { + // FIXME: C++ stdlib formatters break with incomplete types (e.g. + // `std::vector &`). Remove ObjC restriction once

[Lldb-commits] [PATCH] D137983: [lldb] Disable looking at pointee types to find synthetic value for non-ObjC

aeubanks added a comment. also I'm don't understand how this code doesn't infinite recurse on ObjC and can't trace it because I don't have a mac if anybody has an actual way of fixing this I'd be happy with that too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D137983: [lldb] Disable looking at pointee types to find synthetic value for non-ObjC

aeubanks added a comment. Herald added a subscriber: JDevlieghere. lldb crash repro $ cat /tmp/a.cc #include void f(std::vector& v) { *(volatile int*) nullptr = 0; } $ cat /tmp/main.cc #include void f(std::vector& v); int main() { std::vector v ;

[Lldb-commits] [PATCH] D137983: [lldb] Disable looking at pointee types to find synthetic value for non-ObjC

aeubanks created this revision. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. After D134378 , we started seeing crashes with incomplete types (in the context of