[Lldb-commits] [PATCH] D139649: [lldb] Make ParseTemplateParameterInfos return false if there are no template params

2022-12-12 Thread Arthur Eubanks via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG81f1f6db40ab: [lldb] Make ParseTemplateParameterInfos return false if there are no template… (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D139649: [lldb] Make ParseTemplateParameterInfos return false if there are no template params

2022-12-09 Thread Arthur Eubanks via Phabricator via lldb-commits
aeubanks updated this revision to Diff 481711. aeubanks added a comment. revert one change to make this nfc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139649/new/ https://reviews.llvm.org/D139649 Files:

[Lldb-commits] [PATCH] D139649: [lldb] Make ParseTemplateParameterInfos return false if there are no template params

2022-12-09 Thread Michael Buch via Phabricator via lldb-commits
Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1251 + if (has_template_params && + ParseTemplateParameterInfos(die, template_param_infos)) { +template_function_decl =

[Lldb-commits] [PATCH] D139649: [lldb] Make ParseTemplateParameterInfos return false if there are no template params

2022-12-08 Thread Arthur Eubanks via Phabricator via lldb-commits
aeubanks added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1251 + if (has_template_params && + ParseTemplateParameterInfos(die, template_param_infos)) { +template_function_decl =

[Lldb-commits] [PATCH] D139649: [lldb] Make ParseTemplateParameterInfos return false if there are no template params

2022-12-08 Thread David Blaikie via Phabricator via lldb-commits
dblaikie added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1251 + if (has_template_params && + ParseTemplateParameterInfos(die, template_param_infos)) { +template_function_decl =

[Lldb-commits] [PATCH] D139649: [lldb] Make ParseTemplateParameterInfos return false if there are no template params

2022-12-08 Thread Arthur Eubanks via Phabricator via lldb-commits
aeubanks created this revision. Herald added a reviewer: shafik. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This factors out the check from various callers. Repository: rG LLVM Github Monorepo