[Lldb-commits] [PATCH] D139945: [lldb] Add scripted process launch/attach option to platform commands

mib updated this revision to Diff 502259. mib added a comment. Fix build failures after rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139945/new/ https://reviews.llvm.org/D139945 Files: lldb/include/lldb/API/SBAttachInfo.h lldb/include/lldb/API/SBStructuredData.h lldb/incl

[Lldb-commits] [PATCH] D139945: [lldb] Add scripted process launch/attach option to platform commands

mib updated this revision to Diff 494110. mib added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139945/new/ https://reviews.llvm.org/D139945 Files: lldb/bindings/interface/SBAttachInfo.i lldb/include/lldb/API/SBAttachInfo.h lldb/include/lldb/API/SBStructuredDa

[Lldb-commits] [PATCH] D139945: [lldb] Add scripted process launch/attach option to platform commands

mib added a comment. In D139945#4011466 , @labath wrote: > In D139945#4009427 , @JDevlieghere > wrote: > >> In D139945#3999351 , @labath wrote: >> >>> For a "plugin", the

[Lldb-commits] [PATCH] D139945: [lldb] Add scripted process launch/attach option to platform commands

labath added a comment. In D139945#4009427 , @JDevlieghere wrote: > In D139945#3999351 , @labath wrote: > >> For a "plugin", the scripted process is sure getting a lot of special >> handling in generic code. (I

[Lldb-commits] [PATCH] D139945: [lldb] Add scripted process launch/attach option to platform commands

JDevlieghere added a comment. In D139945#3999351 , @labath wrote: > For a "plugin", the scripted process is sure getting a lot of special > handling in generic code. (I know this isn't being introduced here, but I > wasn't involved in the previous revie

[Lldb-commits] [PATCH] D139945: [lldb] Add scripted process launch/attach option to platform commands

labath added a comment. For a "plugin", the scripted process is sure getting a lot of special handling in generic code. (I know this isn't being introduced here, but I wasn't involved in the previous review -- and I'm not actually sure I want to be involved here). I don't think that's necessari

[Lldb-commits] [PATCH] D139945: [lldb] Add scripted process launch/attach option to platform commands

mib created this revision. mib added reviewers: jingham, labath, JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch does several things: First, it refactors the `CommandObject{,Platform}P